[1.3][1.4] JCSSUtil.php pageaddvar prototype/jquery order and file naming

[espaan]

Hi,
I'm testing out a new theme conversion with Bootstrap and jQuery.

1. jquery / prototype ordering
   When I'm using

    {pageaddvar name='javascript' value='prototype'}
    {pageaddvar name='javascript' value='jquery'}

with the current JCSSUtil.php (1.3 for sure and 1.4 afais) the order is always jquery first, then noconflict.js or jquery_config.js in 1.4 and only then prototype. For the noconflict to work properly afaik the prototype should be loaded first.
So

<script type="text/javascript" src="javascript/jquery/jquery.min.js"></script>
<script type="text/javascript" src="javascript/jquery/noconflict.js"></script>
<script type="text/javascript" src="javascript/ajax/proto_scriptaculous.combined.min.js"></script>
<script type="text/javascript" src="javascript/helpers/Zikula.js"></script>

with a small change in the JCSSUtil.php by putting prototype above in the $scripts array
https://github.com/zikula/core/blob/1.4/src/lib/util/JCSSUtil.php#L365
and
https://github.com/zikula/core/blob/1.3/src/lib/util/JCSSUtil.php#L336
that one will always be loaded before jquery and noconflict and the order will be

<script type="text/javascript" src="javascript/ajax/proto_scriptaculous.combined.min.js"></script>
<script type="text/javascript" src="javascript/jquery/jquery.min.js"></script>
<script type="text/javascript" src="javascript/jquery/noconflict.js"></script>
<script type="text/javascript" src="javascript/helpers/Zikula.js"></script>

2. follow in [1.3.x] Add jQuery 1.11.2 with migrate as option in 1.3.x  #2223 (Only 1.3.x relevant) Furthermore it would be really convenient to rename the jQuery file to a filename without version number. In that way people using 1.3.x can also easily update to a later version of jQuery just by replacing this file with a newer one. And then no code fiddling is needed. In the code example above I already this in my install BTW. So you don't see the version number any more. In 1.4.x jQuery is loaded via composer and does not have a versionnr.

3. follow in [1.3.x] Add jQuery 1.11.2 with migrate as option in 1.3.x  #2223 (only 1.3.x relevant) it would be nice to add a jquery-migrate to the list of pageaddvar options for the reason mentioned under 2. When people use a jquery above 1.9.x then they can also load jq-migrate via pageaddvar and it works. In 1.4.x this is already the case, since jQ > 1.9 is used.

I will make a PR later on for this.

[craigh]

refs #1324 (currently scheduled for 2.0.0)

[Guite]

@espaan how about moving 2) and 3) into another issue to keep things separated?

[espaan]

A good idea. I did it this way since I wanted to make 1 pr for these points :-)

Op 8 jan. 2015 om 19:52 heeft Axel Guckelsberger notifications@github.com het volgende geschreven:

@espaan how about moving 2) and 3) into another issue to keep things separated?

—
Reply to this email directly or view it on GitHub.

[craigh]

For the noconflict to work properly afaik the prototype should be loaded first.

is this documented somewhere?

[craigh]

Furthermore it would be really convenient to rename the jQuery file to a filename without version number.

this may be difficult since we are loading the library from composer/component

[espaan]

@craigh I'm reading that the order is always first prototype and then jQ and then noconflict. But not that i is absolutely necessary.
http://api.jquery.com/jquery.noconflict/ says to first load the other lib then jqyery and then no conflict.
also http://learn.jquery.com/using-jquery-core/avoid-conflicts-other-libraries/

The loading from composer is indeed true for 1.4.x, but in 1.3.x jQuery is just within Zikula. For 1.4.x it is also not a problem, since version nr is not in the name already.

3. also only holds for 1.3.x, since in 1.4.x it is already there.

[espaan]

Point 2) and 3) can be followed up in #2223
But there will be one PR (per Core version of course) with the change :-)