-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsgettext FC #2601
Labels
Milestone
Comments
maybe a duplicate of #2487 |
What do you think about this? |
yes that is the first choice in the related ticket 😉 (#2487) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
need to figure out how to deal with
{pageaddvar name="jsgettext" value="module_news_js:News"}
going forward.Not sure it ever properly worked in the first place.
translation for >=1.4 is different anyway and JS translation must be accommodated.
refs #2487
currently
pageAddAsset()
doesn't allowjsgettext
so it is filtered out and set as a pagevar instead. Obviously this is wrong, but the system won't work in twig anyway, so it probably doesn't matter until a solution is implemented in general.@phaidon
The text was updated successfully, but these errors were encountered: