Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsgettext FC #2601

Closed
craigh opened this issue Sep 19, 2015 · 3 comments
Closed

jsgettext FC #2601

craigh opened this issue Sep 19, 2015 · 3 comments

Comments

@craigh
Copy link
Member

craigh commented Sep 19, 2015

need to figure out how to deal with {pageaddvar name="jsgettext" value="module_news_js:News"} going forward.
Not sure it ever properly worked in the first place.
translation for >=1.4 is different anyway and JS translation must be accommodated.
refs #2487

currently pageAddAsset() doesn't allow jsgettext so it is filtered out and set as a pagevar instead. Obviously this is wrong, but the system won't work in twig anyway, so it probably doesn't matter until a solution is implemented in general.

@phaidon

@craigh
Copy link
Member Author

craigh commented Oct 1, 2015

maybe a duplicate of #2487

@Kaik
Copy link
Contributor

Kaik commented Nov 23, 2015

@craigh
Copy link
Member Author

craigh commented Nov 23, 2015

yes that is the first choice in the related ticket 😉 (#2487)

@craigh craigh modified the milestones: 1.4.2, 1.4.3 Feb 26, 2016
@craigh craigh modified the milestones: 1.4.3, 1.4.4 Jul 11, 2016
@Guite Guite modified the milestones: 1.4.4, 1.4.5 Sep 2, 2016
@Guite Guite modified the milestones: 1.4.5, 1.4.6 Dec 29, 2016
@craigh craigh mentioned this issue Dec 29, 2016
3 tasks
@Guite Guite added this to the 1.4.5 milestone Dec 30, 2016
@Guite Guite removed this from the 1.4.6 milestone Dec 30, 2016
@craigh craigh closed this as completed Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants