refactored search module to 2.0 style #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
| $args['sortorder'] = 'count'; | ||
| } | ||
|
|
||
| $items = array(); | ||
| $items = []; | ||
|
|
||
| // Security check | ||
| if (!SecurityUtil::checkPermission('ZikulaSearchModule::', '::', ACCESS_OVERVIEW)) { |
There was a problem hiding this comment.
IMO, all security checks should be done at the Controller level (and use shortcut to new service).
There was a problem hiding this comment.
I didn't refactor the api yet on purpose for two reasons: 1st it is quite difficult to incorporate old search plugins and 2nd #1753 is about Twig migration. So my primary focus is on getting things converted to Twig and Sf Forms.
Closed
Guite
changed the title
* refactored admin module to 2.0-style * fixed styleci issues * use placeholder attribute
Guite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the search module to new controller, Twig, Symfony Forms, etc.
Todos
The search block's form type must be able to handle checkboxes for the module plugins. Tracked in #2861