Fully implement Twig templating layer #1753

craigh · 2014-06-12T17:26:03Z

craigh · 2014-10-27T19:52:02Z

This may need to be bumped all the way to 2.0.0 because as far as I can tell, it will be very difficult to provide a forward compatibility layer where some site extensions use Twig and others use Smarty. I think it will need to be all or nothing and that is a serious BC break. perhaps I do not understand and there is a way to make it work, but in the limited investigation I have made, I can't see it.

craigh · 2014-11-19T22:36:10Z

something to consider: https://github.com/liip/LiipThemeBundle

craigh · 2014-12-17T20:55:47Z

My comment from Oct 27 is wrong. I am currently utilizing Twig templates in conjunction with Smarty templates. you have to force the 'legacy mode' to engage.

you can see the controller here: https://github.com/craigh/BreakIt/blob/master/Controller/NewController.php

Forms also work. I am testing something right now that I will push to BreakIt asap (only as a demo - it doesn't break anything on purpose). So, IMO, the only real issue left is theming and I'm not sure how to solve that at the moment.

Guite · 2014-12-18T08:17:44Z

Added a task list to this task above.

Kaik · 2014-12-18T15:42:17Z

@craigh I have played with sf2 and twig before, actually it was looking similar to what you have in breakeIt module, and I have stopped on translations they worked only for zikula domain (inside twig template) while there was no translation using module domain. Module tranlsations are working correctly when using smarty. I wonder if you had any experiences with it.

craigh · 2014-12-18T15:51:44Z

@Kaik it may depend on if you mean in the controller or the twig template.

Kaik · 2014-12-18T17:23:48Z

Actually I have checked in controller, form builder and in template but that was few months ago and things may have changed since then. I will try to check it all again to see how it is acting now, hopefully I will be able to do all zk things before new year.

craigh · 2014-12-19T01:37:24Z

I doubt the behavior has changed much, since I think I'm the only one working on it atm and I don't even know where to start 😉

craigh · 2014-12-19T01:39:31Z

There is this: https://github.com/zikula/core/blob/1.4/src/lib/Zikula/Bundle/CoreBundle/Twig/Extension/GettextExtension.php

which I suppose should work but there are some undefined functions there which is confusing.

craigh · 2014-12-19T01:40:59Z

ah - here maybe something that is an issue:

https://github.com/zikula/core/blob/1.4/src/lib/Zikula/Bundle/CoreBundle/Twig/Extension/GettextExtension.php#L10

Kaik · 2014-12-19T13:35:13Z

Now I remember I was trying to fix some of twig related stuff in the other file in same folder CoreExtensions.php Most probably I have looked at GettextExtension.php but for me it looked fine... now I see I have missed that @ todo bit and looks like this is exactly what is missing. I have still one doubt about this because I have tried to pass domain directly and it did not work either but might be that I messed something.

craigh · 2014-12-19T16:10:44Z

@Kaik can you give me some idea how to begin working on the problem? I never use anything but English so I'm pretty dumb about the translation system in general (in other words, start from the beginning)

craigh · 2014-12-24T14:19:26Z

here is another blog about how they solved their theme problem http://hugogiraudel.com/2013/11/12/themes-layouts-twig/

matheo · 2014-12-24T15:14:09Z

Nice material Craig! I will share some thoughts on this topic later because
this is my passion :)

| Q | A | ----------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | n/a | Fixed tickets | #2671 | Refs tickets | #1753 | License | MIT | Changelog updated | yes also update /docs structure for improved understanding. Implemented system of activating/deactivating themes. should close #2671. Also moved most Theme related classes/files from Core to ThemeModule.

| Q | A | ----------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #2600 | Refs tickets | #1753 | License | MIT | Doc PR | - | Changelog updated | yes - Upgrade ExtensionsModule to Core-2.0 spec except the handling of module and system plugins. - Consolidate all hook-related classes and files into new HookBundle - Correct issue with hook display requiring smarty - fixes #2600 - Add 'info' type of flash message

| Q | A | ----------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | - | Refs tickets | #2034, #1753 | License | MIT | Changelog updated | yes

@Guite

* refactored pagelock module to 2.0 style * typo * added missing service argument * several improvements * minor fixes * several amendments * rename method * typo * minor fix for composer.json * minor docblock fix * minor amendments * minor cleanup regarding Multisites * Fixed StyleCI issue * update composer.lock updates - paragonie/random_compat (v1.2.2 => v1.4.1) - ezyang/htmlpurifier dev-master (92aabf2 => 25db9e1) - abeautifulsite/jquery-minicolors dev-master (8039c59 => 543116f) * Rename setasdefault.html.twig to setAsDefault.html.twig * Rename viewmodulelist.html.twig to viewModuleList.html.twig * Rename moduleservices.html.twig to moduleServices.html.twig * Revert changes in admin api * updated clickjacking protection listener * use array shorthand syntax, added some missing docblocks * fixed regression * correct string translation. refs zikula-modules/MediaModule#64 * use non-aliased service name. refs #2808 @Guite * use array shorthand syntax, added some missing docblocks (reverted from commit 93f6a61) * corrected method call of variable api, fixed #2812 * disable dependency check for vendors in modules. * disable dependency check for vendors in modules. * Don't use PHP_VERSION constant * Removed {break} Smarty tag * Fix output of theme maincontent to NOT automatically include a unique div wrapper. Move wrapper to AbstractTheme. | Q | A | ----------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | - | Refs tickets | #2819 | License | MIT | Changelog updated | no * Added issue and pull request tempaltes, closes #2778. * update composer.json to include robloach/component-install as an explicit dependency. update composer.lock * update method for php strict standards * Remove dev-master for two dependencies. * Added Vagrant support. * correct typehint in ZikulaPhpFileExtractor * | Q | A | ----------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #2823 | Refs tickets | - | License | MIT | Doc PR | - | Changelog updated | no * minor correction to Categories Form Type * correct display of developer notice in Admin panel for new admin header. fixes #2828 * grduingly provide backward compatible installer for 'transition' modules. fixes #2831 * Make Bootstrap theme site default. | Q | A | ----------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | - | Refs tickets | - | License | MIT | Changelog updated | yes ## Description Make Bootstrap theme site default (new features added, blocks and permissions adjusted specific to theme). Improved compatibility of zikula-specific bootstrap overrides with respect to navbars. Provide method for customizing Bootstrap path in Core-2.0 themes ## Todos - [x] Tests - [x] Documentation - [x] Changelog * update composer.lock * Create Theme permission at installation. Include selected theme in permission check. * update composer.lock cc/ @Guite * Updated Symfony version * update Core version to 1.4.3 * update changelog for 1.4.3 * refactor Settings module to Core-2.0 spec. | Q | A | ----------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | - | Refs tickets | #2034, #1753 | License | MIT | Changelog updated | yes * additional features to bootstrap topnav login button to allow improved access to user-related functions. * minor css fix to bootstrap theme topnav login block * update composer.lock - Removing nikic/php-parser (v1.4.1) - Installing nikic/php-parser (v2.0.1) - Removing jms/translation-bundle (1.2.1) - Installing jms/translation-bundle (1.2.2) - Removing monolog/monolog (1.18.1) - Installing monolog/monolog (1.18.2) - Updating ezyang/htmlpurifier dev-master (096064d => 2e15d7a) Checking out 2e15d7a4dadb08ccdac3f060dcf81112e607b6c4 * fix error on creation of new ExtendedMenublock * fix StyleCi error * update composer.lock. force 1.4 branch of php-parser - Removing composer/installers (v1.0.23) - Installing composer/installers (v1.0.24) - Removing nikic/php-parser (v2.0.1) - Installing nikic/php-parser (v1.4.1) * Form improvements (#2846) * update form extensions to Sy2.8 and add a few features @Guite 😄 * update changelog * support multiple help elements (#2847) * support multiple help elements * Check for empty help values * Adjust form theme template to use macros to avoid duplicate code. Add alert text feature. @Guite * Added information about using help arrays * correct upgrade of 'hybrid' 1.4/2.0 modules * allow alerts on checkboxes also. * refactored pagelock module to 2.0 style * typo * added missing service argument * several improvements * minor fixes * several amendments * rename method * typo * minor fix for composer.json * minor docblock fix * minor amendments

Guite · 2016-07-14T15:11:51Z

Closed 😄

craigh added this to the 1.5.0 milestone Jun 12, 2014

craigh added Feature labels Jun 12, 2014

craigh changed the title ~~Fully implement Twig tempting layer~~ Fully implement Twig templating layer Jun 12, 2014

This was referenced Jun 12, 2014

controlling load order of stylesheets #1324

Closed

Use Twig for 1.4 target Guite/MostGenerator#571

Closed

Guite mentioned this issue Oct 6, 2014

Migrate to Symfony forms #2034

Closed

Guite modified the milestones: 1.5.0, 2.0.0 Dec 22, 2014

Guite added the Blocker label Dec 22, 2014

craigh mentioned this issue Feb 19, 2015

Finalize gettext implementation for ZikulaTwig #2260

Closed

craigh mentioned this issue Sep 10, 2015

Andreas08 to twig + bootstrap #2577

Merged

4 tasks

craigh mentioned this issue Feb 10, 2016

Refactor ThemeModule to Core-2.0 Spec #2762

Merged

craigh mentioned this issue Mar 2, 2016

Refactor ExtensionsModule to Core-2.0 (except Plugin handling). #2773

Merged

craigh mentioned this issue Mar 7, 2016

Add Admin Interface Twig functions and controllers #2793

Merged

craigh mentioned this issue Mar 28, 2016

Refactor Settings module to Core-2.0 spec. #2832

Merged

Guite mentioned this issue Apr 25, 2016

refactored mailer module to 2.0 style #2866

Merged

Guite mentioned this issue May 29, 2016

refactored securitycenter module to 2.0-style #2890

Merged

Guite mentioned this issue Jun 15, 2016

updated permissions module for 2.0 spec #2896

Merged

Guite assigned Guite and craigh Jun 15, 2016

Guite mentioned this issue Jun 29, 2016

migrated Groups module to 2.0-spec #2907

Merged

craigh mentioned this issue Jul 1, 2016

UsersModule refactor #2851

Merged

Guite mentioned this issue Jul 13, 2016

migrated routes module to 2.0-spec #2921

Merged

Guite added a commit that referenced this issue Jul 13, 2016

migrated routes module to 2.0-spec, refs #1753

161ffa1

Guite modified the milestones: 1.4.3, 2.0.0-beta1 Jul 14, 2016

Guite mentioned this issue Jul 14, 2016

migrated categories to 2.0-spec #2923

Merged

Guite closed this as completed Jul 14, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fully implement Twig templating layer #1753

Fully implement Twig templating layer #1753

craigh commented Jun 12, 2014 •

edited by Guite

Loading

craigh commented Oct 27, 2014

craigh commented Nov 19, 2014

craigh commented Dec 17, 2014

Guite commented Dec 18, 2014

Kaik commented Dec 18, 2014

craigh commented Dec 18, 2014

Kaik commented Dec 18, 2014

craigh commented Dec 19, 2014

craigh commented Dec 19, 2014

craigh commented Dec 19, 2014

Kaik commented Dec 19, 2014

craigh commented Dec 19, 2014

craigh commented Dec 24, 2014

matheo commented Dec 24, 2014

Guite commented Jul 14, 2016

Fully implement Twig templating layer #1753

Fully implement Twig templating layer #1753

Comments

craigh commented Jun 12, 2014 • edited by Guite Loading

craigh commented Oct 27, 2014

craigh commented Nov 19, 2014

craigh commented Dec 17, 2014

Guite commented Dec 18, 2014

Kaik commented Dec 18, 2014

craigh commented Dec 18, 2014

Kaik commented Dec 18, 2014

craigh commented Dec 19, 2014

craigh commented Dec 19, 2014

craigh commented Dec 19, 2014

Kaik commented Dec 19, 2014

craigh commented Dec 19, 2014

craigh commented Dec 24, 2014

matheo commented Dec 24, 2014

Guite commented Jul 14, 2016

craigh commented Jun 12, 2014 •

edited by Guite

Loading