Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more explicitly define isInstalling() etc. #2974

Closed
craigh opened this issue Aug 17, 2016 · 2 comments
Closed

more explicitly define isInstalling() etc. #2974

craigh opened this issue Aug 17, 2016 · 2 comments
Labels
Core Install/Upgrade Feature
Milestone
1.4.6

Comments

@craigh
Copy link
Member

craigh commented Aug 17, 2016 •
edited
Loading

It is currently unclear in the core what isInstalling() and isUpgrading() mean and how they are and should be used. This needs to be clarified and then the core code must be aligned and refactored.
@craigh craigh added this to the 2.0.0-beta1 milestone Aug 17, 2016
@craigh
Copy link
Member Author

craigh commented Aug 27, 2016

currently when the core is upgrading, a parameter is added to the container upgrading:true and this can be tested in the process. I do not think this is written to parameters.yml but only continually added by the upgrading controller. This same strategy could be used for installing:true and this would simplify the issue I think.

@Guite Guite modified the milestones: 2.0.0-beta1, 2.0.0 Nov 5, 2016
@craigh craigh modified the milestones: 1.4.6, 2.0.0 Jan 10, 2017
@craigh
Copy link
Member Author

craigh commented Jan 10, 2017

this is complete.

@craigh craigh closed this as completed Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core Install/Upgrade Feature
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
2 participants
@Guite @craigh