Error pages - issues

[Kaik]

Q	A
Zikula Version	2.x.x
PHP Version	7.x

I have just started playing with error pages and things are kind of wrong!
So first of all the only way, I have tried is to add custom error404 template in app/Resources... just as Symfony stated and it does work but there are issues with it.
All those are with env prod debug false and 404 error page does not exist like /loginxx
Issues

1. no automatic assets loaded (bootstrap, jquery etc...) apart from those that are loaded in theme header
   I'm investigating this now...

2. This is a bit more complicated issue. I have a theme with few "master" templates with no container with container-fluid and with normal container (bootstrap). This is configured in theme.yml via realms and per module/pattern and the problem is that error page is in the realm of a module/pattern that is throwing an error this is making a problem because I cannot specify error page to fit all those custom master templates.
   Best solution would be to create error realm.

3. Well I do not know if this is not already possible but simle theme specyfic error pages I have not found a way to place error pages in theme.

[Kaik]

Now I can see that issue number one is about what and where is throwing an error in my case I use /loginxxx url to throw an error and another wrong url with controller with param converter. In case of /loginxxx DefaultPageAssetSetterListener is not firing while in case of a controller 404 error it does work.

So I have found two ways of solving the first issue and

1. just add all assets into theme header.
2. AddJsConfigListener does work properly in both cases and it uses KernelEvents::RESPONSE instead of KernelEvents::REQUEST so I have changed DefaultPageAssetSetterListener to use KernelEvents::RESPONSE and it works

Please let me know if this is a good idea to use kernel response, in this case, someone made it this way and I do not know the reason.

[Kaik]

In case of issue 2/3 I think we could create error realm for error pages so all 5xx and 4xx codes could be templated inside new error realm.

[craigh]

closed by ad84476

[craigh]