Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Blocks] theme install should add new blockpositions #4228

Closed
craigh opened this issue Apr 9, 2020 · 1 comment · Fixed by #4519
Closed

[Blocks] theme install should add new blockpositions #4228

craigh opened this issue Apr 9, 2020 · 1 comment · Fixed by #4519
Assignees
@craigh
Labels
Feature
Milestone
3.1.0

Comments

@craigh
Copy link
Member

craigh commented Apr 9, 2020

When a theme is installed, it should scan the theme.yaml file for blockpositions and then make sure those block positions are added to the available positions. On uninstall, maybe unique positions could be removed if they are not used by other themes (this could be more difficult tho).
@craigh craigh added the Feature label Apr 9, 2020
@craigh craigh added this to the 3.1.0 milestone Apr 9, 2020
@Kaik

This comment has been minimized.

Sign in to view
@Guite Guite changed the title Theme install should add new blockpositions [Theme] theme install should add new blockpositions Jul 15, 2020
@craigh craigh self-assigned this Jul 19, 2020
@craigh craigh changed the title [Theme] theme install should add new blockpositions [Blocks] theme install should add new blockpositions Oct 10, 2020
craigh added a commit that referenced this issue Oct 10, 2020
@craigh
Add new block positions automatically on theme installation fixes #4228
18db99c
@craigh craigh mentioned this issue Oct 10, 2020
Merged
craigh added a commit that referenced this issue Oct 10, 2020
@craigh
Add new block positions automatically on theme installation fixes #4228…
896e9e9 
… (#4519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craigh craigh

Labels
Feature
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Add new block positions automatically on theme installation fixes #4228 zikula/core
2 participants
@craigh @Kaik