Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] remove symfony/symfony dependency #4352

Closed
craigh opened this issue Jun 18, 2020 · 4 comments
Closed

[General] remove symfony/symfony dependency #4352

craigh opened this issue Jun 18, 2020 · 4 comments
Assignees
Milestone

Comments

@craigh
Copy link
Member

craigh commented Jun 18, 2020

remove symfony/symfony dependency and replace with only needed components.

this is required as part of https://symfony.com/doc/current/setup/flex.html

at least

but also, just good practice and also current best-practice.

@craigh craigh added the Feature label Jun 18, 2020
@craigh craigh added this to the 3.0.1 milestone Jun 18, 2020
@craigh craigh self-assigned this Jun 18, 2020
@craigh craigh modified the milestones: 3.0.1, 3.1.0 Jun 18, 2020
@Guite
Copy link
Member

Guite commented Jun 18, 2020

isn't this necessarily for 4.0.0 ?
because if we remove something this is a BC break

@craigh
Copy link
Member Author

craigh commented Jun 18, 2020

the goal would be to not remove anything 😄

I believe this simply done.

@Guite
Copy link
Member

Guite commented Jun 18, 2020

Then the description above is misleading:

replace with only needed components

@craigh
Copy link
Member Author

craigh commented Jun 18, 2020

possible you are right. I've done some preliminary research. As far as I can tell, the core is not using

  • component/browser-kit // used in functional tests
  • component/css-selector // used in functional tests
  • component/dom-crawler // used in functional tests
  • component/http-client ?? no? maybe used in functional tests?
  • component/inflector
  • component/ldap
  • component/lock
  • component/process ??
  • component/property-access
  • component/property-info
  • component/serializer
  • component/stopwatch
  • component/templating (maybe used by maker?)
  • component/var-dumper
  • component/var-exporter
  • component/web-link

@craigh craigh added the Refactor label Jul 2, 2020
@Guite Guite changed the title remove symfony/symfony dependency [General] remove symfony/symfony dependency Jul 15, 2020
@craigh craigh closed this as completed in ea74c1f Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants