Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to runtime implementations #4522

Merged
merged 5 commits into from
Oct 12, 2020
Merged

refactor to runtime implementations #4522

merged 5 commits into from
Oct 12, 2020

Conversation

craigh
Copy link
Member

@craigh craigh commented Oct 11, 2020 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets -
Refs tickets #4520
License MIT
Changelog updated yes

Description

refactor to runtime implementations

Todos

  • Changelog

@craigh craigh added this to the 3.1.0 milestone Oct 11, 2020
@craigh craigh requested a review from Guite October 11, 2020 12:51
@Guite
Copy link
Member

Guite commented Oct 11, 2020

Do you intend to continue with further system modules and core bundle, too?

@craigh
Copy link
Member Author

craigh commented Oct 11, 2020

Do you intend to continue with further system modules and core bundle, too?

yes. this is currently incomplete.

@craigh
Copy link
Member Author

craigh commented Oct 12, 2020

@Guite - I think this is complete, please take a closer look.

@craigh craigh requested a review from Guite October 12, 2020 00:28
Guite
Guite approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@Guite Guite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :-)

@craigh craigh merged commit 155c910 into master Oct 12, 2020
@craigh craigh deleted the _4520_twigRuntime branch October 12, 2020 09:59
@craigh
Copy link
Member Author

craigh commented Oct 12, 2020

@Guite, I did not convert RoutesModule. I figured you would be updating the generator.

@Guite
Copy link
Member

Guite commented Oct 12, 2020

I figured you would be updating the generator.

Indeed 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guite Guite Guite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@craigh @Guite