Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageSize needs to be cast to int #4709

Closed
paustian opened this issue Jul 30, 2021 · 1 comment
Closed

pageSize needs to be cast to int #4709

paustian opened this issue Jul 30, 2021 · 1 comment
Labels
Milestone

Comments

@paustian
Copy link
Member

Expected behaviour - What did you expect to happen?

You can load the default page in the admin module

Current behavior - What happened instead?

You cannot load the default page in the Admin module

Possible solution

Tim Paustian  1:29 PM
Another small cast that needs to be done….
https://github.com/zikula/core/blob/0a211c5e2f4531ad10a35b4fc37ae540fcba31b7/src/system/AdminModule/Controller/AdminController.php#L66

The code is:
$pageSize = $this->getVar('itemsperpage');

It should be
pageSize = (int)$this->getVar('itemsperpage');

Steps to reproduce

Go to the admin module default page
...

Context

No response

Zikula version

3.0.3

PHP version

7.4.x

@paustian paustian added the Bug label Jul 30, 2021
@Guite Guite added this to the 3.1.0 milestone Jul 30, 2021
@Guite Guite closed this as completed in 30d333d Jul 30, 2021
@Guite
Copy link
Member

Guite commented Jul 30, 2021

for reference: beside 30d333d there was another fix at 52674d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants