Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes backward-compatibility for older modules that return NULL with ModUtil::getModule(), such as the current Profile module. #1452

Closed
wants to merge 1 commit into from

Conversation

shefik
Copy link
Contributor

@shefik shefik commented Nov 29, 2013

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
Refs tickets zikula-modules/Profile#21
License MIT
Doc PR

…ModUtil::getModule(), such as the current Profile module.
@craigh
Copy link
Member

craigh commented Nov 29, 2013

I'm not sure this is the right solution. It appears that profile has been partially converted to the new module standard. The conversion to namespaces should simply be completed instead of adding yet another compatibility layer IMO

@shefik
Copy link
Contributor Author

shefik commented Nov 29, 2013

@craigh I can agree with what you said. How about we just consider this a temporary solution, and remove it whenever the Profile module is completed? Without this fix, the user's account page is broken here:

/index.php?module=users&type=user&func=index

@ghost
Copy link

ghost commented Nov 29, 2013

Craigh is right. The module has half converted so it's not a core problem. The right way is to refactor Profile.

@ghost ghost closed this Nov 29, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants