check for proper inheritance before attaching event listener class #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
craigh
commented
Jan 9, 2014
craigh
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| Refs tickets | - |
| License | MIT |
| Doc PR | - |
craigh
added a commit
to zikula-modules/Profile
that referenced
this pull request
Jan 9, 2014
Those updating dev versions should delete the row in the modvars table where `modname=/Eventhanders` AND `name=ZikulaProfileModule` - it shouldn't break if this is not done (pending PR zikula/core#1543), but continuous errors will be logged due to the handlers in the DB no longer existing.
|
ping @Drak |
craigh
added a commit
to zikula-modules/Legal
that referenced
this pull request
Jan 9, 2014
Those updating dev versions should delete the row in the modvars table where `modname=/Eventhanders` AND `name=ZikulaLegalModule` - it shouldn't break if this is not done (pending PR zikula/core#1543), but continuous errors will be logged due to the handlers in the DB no longer existing.
ghost
pushed a commit
that referenced
this pull request
Jan 10, 2014
check for proper inheritance before attaching event listener class
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.