-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI against Ruby 3.0 #224
CI against Ruby 3.0 #224
Conversation
* which prevents the CI builds with Ruby 3 from succeeding * and is no longer listed in the build list of our CI
Rails 5 doesn't work with Ruby 3 See: rails/rails#40938
@@ -15,10 +15,4 @@ platform :ruby do | |||
gem 'sqlite3', '~> 1.3.0' | |||
end | |||
|
|||
platforms :rbx do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rbx
has been dropped from our build target since this commit .
Can we also remove rbx
from gemfiles
like this ?
(Even bundle install
fails with Ruby 3 like this)
- rvm: 3.0.0 | ||
gemfile: gemfiles/rails_5.1.gemfile | ||
- rvm: 3.0.0 | ||
gemfile: gemfiles/rails_5.2.gemfile | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluding these Rails 5.x and Ruby 3 combinations
from the build target.
Because Rails 5 doesn't support Ruby 3.
See: rails/rails#40938
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete any old gem files and then lets merge/call it a day
Thank you for the comment ! Let me ask,
Q: Which gemfiles should we regard as old ? README says,
So I thought we shouldn't remove any of these existing gemfiles, whose versions are
|
So, could anybody merge this PR ? |
Thank you for merging. |
Hi.
I've tried some fix to make the CI status green against Ruby 3.
Removing
:rbx
specifications from.gemfile
It seems that the version specification of
rubysl
doesn't allow Ruby 3.0 (See: the failing CI's log ).I've tried to find some web source about 3.0 support of
rubysl
but I could not.By the way, it also seems that our CI doesn't list
rbx
as its build target.So I found it not necessary to get the problem fixed, and removed
platforms :rbx
specifications from all the.gemfile
.Is it OK ? I'm not certain if it's ok for this repository.
I'm glad if you see the commit comments to figure out what I did.
Thank you.
ref: #225