Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI against Ruby 3.0 #224

Merged
merged 4 commits into from
Apr 9, 2021
Merged

CI against Ruby 3.0 #224

merged 4 commits into from
Apr 9, 2021

Conversation

tbotaq
Copy link
Contributor

@tbotaq tbotaq commented Feb 6, 2021

Hi.

I've tried some fix to make the CI status green against Ruby 3.

Removing :rbx specifications from .gemfile

It seems that the version specification of rubysl doesn't allow Ruby 3.0 (See: the failing CI's log ).
I've tried to find some web source about 3.0 support of rubysl but I could not.

By the way, it also seems that our CI doesn't list rbx as its build target.

So I found it not necessary to get the problem fixed, and removed platforms :rbx specifications from all the .gemfile.
Is it OK ? I'm not certain if it's ok for this repository.


I'm glad if you see the commit comments to figure out what I did.
Thank you.

ref: #225

* which prevents the CI builds with Ruby 3 from succeeding
* and is no longer listed in the build list of our CI
@@ -15,10 +15,4 @@ platform :ruby do
gem 'sqlite3', '~> 1.3.0'
end

platforms :rbx do
Copy link
Contributor Author

@tbotaq tbotaq Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rbx has been dropped from our build target since this commit .

Can we also remove rbx from gemfiles like this ?
(Even bundle install fails with Ruby 3 like this

- rvm: 3.0.0
gemfile: gemfiles/rails_5.1.gemfile
- rvm: 3.0.0
gemfile: gemfiles/rails_5.2.gemfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluding these Rails 5.x and Ruby 3 combinations from the build target.

Because Rails 5 doesn't support Ruby 3.
See: rails/rails#40938

@tbotaq
Copy link
Contributor Author

tbotaq commented Apr 2, 2021

  • Rebased on the current master
  • Left some comments on the source diff of this PR.(Sorry for too-long description !)

Copy link
Collaborator

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete any old gem files and then lets merge/call it a day

@tbotaq
Copy link
Contributor Author

tbotaq commented Apr 3, 2021

Thank you for the comment !

Let me ask,

delete any old gem files

Q: Which gemfiles should we regard as old ?

README says,

To make users' lives easier, please maintain support for:
Ruby 2.4
ActiveRecord/ActiveSupport from 5.0 through edge

So I thought we shouldn't remove any of these existing gemfiles, whose versions are 5.0 through edge .

rails_5.0.gemfile
rails_5.1.gemfile
rails_5.2.gemfile
rails_6.0.gemfile

@tbotaq
Copy link
Contributor Author

tbotaq commented Apr 8, 2021

  • Looks like no gemfile is old
  • CI green

So, could anybody merge this PR ? :octocat:

@kbrock kbrock self-assigned this Apr 9, 2021
@kbrock kbrock merged commit 1c95f99 into active-hash:master Apr 9, 2021
@tbotaq tbotaq deleted the update-ci-to-work-against-ruby-3 branch April 9, 2021 05:59
@tbotaq
Copy link
Contributor Author

tbotaq commented Apr 20, 2022

Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants