move WaitAllSuccess to thread_pool.h. for some unknown reason the cod…

…e won't build if utils.h imports folly

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>

include/knowhere/comp/thread_pool.h

@@ -22,6 +22,7 @@
 
 #include "folly/executors/CPUThreadPoolExecutor.h"
 #include "folly/futures/Future.h"
+#include "knowhere/expected.h"
 #include "knowhere/log.h"
 
 namespace knowhere {
@@ -211,4 +212,23 @@ class ThreadPool {
 
     constexpr static size_t kTaskQueueFactor = 16;
 };
+
+// T is either folly::Unit or Status
+template <typename T>
+inline Status
+WaitAllSuccess(std::vector<folly::Future<T>>& futures) {
+    static_assert(std::is_same<T, folly::Unit>::value || std::is_same<T, Status>::value,
+                  "WaitAllSuccess can only be used with folly::Unit or knowhere::Status");
+    auto allFuts = folly::collectAll(futures.begin(), futures.end()).get();
+    for (const auto& result : allFuts) {
+        result.throwUnlessValue();
+        if constexpr (!std::is_same_v<T, folly::Unit>) {
+            if (result.value() != Status::success) {
+                return result.value();
+            }
+        }
+    }
+    return Status::success;
+}
+
 }  // namespace knowhere

include/knowhere/utils.h

@@ -16,7 +16,6 @@
 #include <algorithm>
 #include <vector>
 
-#include "folly/futures/Future.h"
 #include "knowhere/binaryset.h"
 #include "knowhere/dataset.h"
 #include "knowhere/expected.h"
@@ -130,22 +129,4 @@ readBinaryPOD(R& in, T& podRef) {
     in.read((char*)&podRef, sizeof(T));
 }
 
-// T is either folly::Unit or Status
-template <typename T>
-inline Status
-WaitAllSuccess(std::vector<folly::Future<T>>& futures) {
-    static_assert(std::is_same<T, folly::Unit>::value || std::is_same<T, Status>::value,
-                  "WaitAllSuccess can only be used with folly::Unit or knowhere::Status");
-    auto allFuts = folly::collectAll(futures.begin(), futures.end()).get();
-    for (const auto& result : allFuts) {
-        result.throwUnlessValue();
-        if constexpr (!std::is_same_v<T, folly::Unit>) {
-            if (result.value() != Status::success) {
-                return result.value();
-            }
-        }
-    }
-    return Status::success;
-}
-
 }  // namespace knowhere