fix:miss wait thread tasks finish in diskann. #357
Conversation
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
|
@cqy123456 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cqy123456, Presburger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
| @@ -530,6 +530,9 @@ int generate_pq_data_from_pivots(const std::string data_file, | |||
| } | |||
| })); | |||
| } | |||
| for (auto &future : futures) { | |||
| future.wait(); | |||
There was a problem hiding this comment.
use knowhere::WaitAllSuccess introduced in #355 to make sure we catch and rethrow possible exceptions in the thread pool task.
issue: #128
/kind improvement