Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:miss wait thread tasks finish in diskann. #357

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix:miss wait thread tasks finish in diskann. #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions thirdparty/DiskANN/src/partition_and_pq.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,9 @@ int generate_pq_data_from_pivots(const std::string data_file,
}
}));
}
for (auto &future : futures) {
future.wait();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use knowhere::WaitAllSuccess introduced in #355 to make sure we catch and rethrow possible exceptions in the thread pool task.

}

futures.clear();
futures.reserve(num_pq_chunks);
Expand Down
Loading