Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add range search capability to indexes with AnnIterator support #508

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add range search capability to indexes with AnnIterator support #508

merged 1 commit into from
Apr 22, 2024

Conversation

zhengbuqian
Copy link
Collaborator

tested using sparse index.

issue: #193
/kind: feature

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed label Apr 18, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.32%. Comparing base (3c46f4c) to head (948a79e).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #508       +/-   ##
=========================================
+ Coverage      0   71.32%   +71.32%     
=========================================
  Files         0       67       +67     
  Lines         0     4429     +4429     
=========================================
+ Hits          0     3159     +3159     
- Misses        0     1270     +1270

see 67 files with indirect coverage changes

@zhengbuqian
Copy link
Collaborator Author

/hold
It won't compile with swig for now

@zhengbuqian zhengbuqian changed the title Add range search capability to indexes with AnnIterator support wip: Add range search capability to indexes with AnnIterator support Apr 18, 2024
@zhengbuqian
Copy link
Collaborator Author

/hold It won't compile with swig for now

fixing in #509, will unhold after that is merged.

@zhengbuqian zhengbuqian changed the title wip: Add range search capability to indexes with AnnIterator support Add range search capability to indexes with AnnIterator support Apr 19, 2024
@zhengbuqian
Copy link
Collaborator Author

/unhold

@buqian-zilliz buqian-zilliz force-pushed the sparse-range-search branch 2 times, most recently from 800a881 to cdb09d7 Compare April 19, 2024 05:36
@mergify mergify bot added the ci-passed label Apr 19, 2024
alexanderguzhva
alexanderguzhva reviewed Apr 19, 2024
View reviewed changes
include/knowhere/index_node.h
if (similarity_metric ? dist <= radius : dist >= radius) {
break;
}
result_id_array[idx].push_back(id);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments from config.h state about (radius, range_filter] or [range_filter, radius), but two ifs right above state about (radius, range_filter) or (range_filter, radius)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments are correct. I wrote the code based on notes in https://milvus.io/docs/v2.3.x/within_range.md#Distance-metrics-influence, which is wrong and will be updated.

src/common/comp/brute_force.cc Show resolved Hide resolved
src/common/comp/brute_force.cc Show resolved Hide resolved
@mergify mergify bot removed the ci-passed label Apr 22, 2024
@zhengbuqian
Add range search capability to indexes with AnnIterator support. Curr…
948a79e 
…ently tested using sparse index.

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@mergify mergify bot added the ci-passed label Apr 22, 2024
@alexanderguzhva
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4efbe82 into zilliztech:main Apr 22, 2024
11 checks passed
@zhengbuqian zhengbuqian deleted the sparse-range-search branch April 23, 2024 01:52
@zhengbuqian zhengbuqian mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderguzhva alexanderguzhva alexanderguzhva left review comments

@chasingegg chasingegg Awaiting requested review from chasingegg

@PwzXxm PwzXxm Awaiting requested review from PwzXxm

Assignees

@alexanderguzhva alexanderguzhva

Labels
approved ci-passed dco-passed kind/feature lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhengbuqian @sre-ci-robot @alexanderguzhva