make DataSet gen helpers available to pyknowhere #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think python3 wheel can now successfully build /unhold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
=========================================
+ Coverage 0 72.36% +72.36%
=========================================
Files 0 63 +63
Lines 0 4291 +4291
=========================================
+ Hits 0 3105 +3105
- Misses 0 1186 +1186 |
cydrain
reviewed
Apr 19, 2024
| @@ -254,8 +254,8 @@ GenDataSet(const int64_t nb, const int64_t dim, const void* xb) { | |||
| return ret_ds; | |||
| } | |||
|
|
|||
| // swig won't compile when using int64_t* or size_t* as parameter | |||
There was a problem hiding this comment.
it's because swig not support api override
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
buqian-zilliz
force-pushed
the
swig-compile-work-around
branch
from
b212f31
to
a3a3059
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PwzXxm, zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind improvement
/hold
This pr only changes the
const int64_t*andconst size_t*arguments ofGenIdsDataSet/GenResultDataSettoconst void*when compiling for swig.When
const int64_t*andconst size_t*is used as argument type, swig build fails due toerror: invalid conversion from 'const long long int*' to 'const int64_t*' {aka 'const long int*'} [-fpermissive].