Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic change user.yaml, optimize deployment render #114

Merged
merged 1 commit into from
May 15, 2024

Conversation

haorenfsa
Copy link
Collaborator

@haorenfsa haorenfsa commented May 15, 2024

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 82.21%. Comparing base (43d4234) to head (3e2e95d).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/controllers/deployment_updater.go 89.18% 2 Missing and 2 partials ⚠️
pkg/controllers/k8s_default_values.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   82.19%   82.21%   +0.02%     
==========================================
  Files          54       54              
  Lines        4913     4932      +19     
==========================================
+ Hits         4038     4055      +17     
- Misses        691      692       +1     
- Partials      184      185       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm looks good to merge label May 15, 2024
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LoveEachDay,haorenfsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
@sre-ci-robot sre-ci-robot removed the lgtm looks good to merge label May 15, 2024
@sre-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@haorenfsa haorenfsa added the lgtm looks good to merge label May 15, 2024
@sre-ci-robot sre-ci-robot merged commit b660ccc into zilliztech:main May 15, 2024
14 checks passed
@haorenfsa haorenfsa deleted the dynamic-config branch May 15, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dynamic config change for milvus v2.4
3 participants