-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing # of children causes prop discrepency. #59
Comments
YourDeveloperFriend
added a commit
to RedRabbitDevelopment/react-slider
that referenced
this issue
Nov 2, 2015
Why is this not merged yet? I am facing the same issue. I also have the similar fix. |
@mpowaga Any update on this PR? I still see this issue, thanks! |
+1 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This bug is apparent when you use both
value
and children. Example:If you add a value to both
value
andlabels
, neither display in the react slider. Here's a jsfiddle demonstrating the bug. The offending code is in the_or
function, which relies onthis.props.children
, but doesn't pull the new children from the updated props incomponentWillReceiveProps
. Here's that same jsfiddle, with a fix, which I will include in a PR.The text was updated successfully, but these errors were encountered: