Fix to let the "insert link" dialog allow anchors

Fixes #1932

zim/gui/pageview/__init__.py

@@ -8188,12 +8188,19 @@ def on_short_link_pref_changed(self, o):
 	def _link_to_text(self, link):
 		if not link:
 			return ''
-		if self.form['short_links'] and link_type(link) == 'page':
+		elif self.form['short_links'] and link_type(link) == 'page':
 				# Similar to 'short_links' notebook property but using uistate instead
-				parts = HRef.new_from_wiki_link(link).parts()
-				if len(parts) > 0:
-					return parts[-1]
-		return link
+				try:
+					parts = HRef.new_from_wiki_link(link).parts()
+				except ValueError:
+					return ''
+				else:
+					if len(parts) > 0:
+						return parts[-1]
+					else:
+						return link
+		else:
+			return link
 
 	def do_response_ok(self):
 		self.uistate['short_links'] = self.form['short_links']

zim/gui/widgets.py

@@ -60,7 +60,7 @@
 from zim.fs import adapt_from_oldfs
 from zim.newfs import FilePath, LocalFile, LocalFolder
 from zim.config import value_is_coord
-from zim.notebook import Notebook, Path, PageNotFoundError
+from zim.notebook import Notebook, Path, HRef, PageNotFoundError
 from zim.parsing import link_type
 from zim.signals import ConnectorMixin
 from zim.notebook.index import IndexNotFoundError
@@ -1982,24 +1982,23 @@ def __init__(self, notebook, path=None):
 		self.file_type_hint = None
 
 	def get_path(self):
-		# Check we actually got a valid path
-		text = self.get_text()
-		if text:
-			type = link_type(text)
-			if type == 'page':
-				return PageEntry.get_path(self)
-			else:
-				return None
-		else:
-			return None
+		# TODO: proper check link syntax, including achor part instead
+		#       of just using PageEntry.get_path()
+		raise NotImplementedError
 
 	def update_input_valid(self):
 		# Switch between path completion and file completion
 		text = self.get_text()
 		if text:
 			type = link_type(text)
 			if type == 'page':
-				PageEntry.update_input_valid(self)
+				try:
+					href = HRef.new_from_wiki_link(text)
+				except ValueError:
+					self.set_input_valid(True)
+				else:
+					self.set_input_valid(href.names or href.anchor)
+						# Should not reduce to empty link
 			#~ elif type == 'file':
 				#~ FileEntry.update_input_valid(self)
 			else: