Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor Links are not handled properly by Link Dialogue Box #1932

Closed
ChristianSilvermoon opened this issue Feb 15, 2022 · 0 comments
Closed

Comments

@ChristianSilvermoon
Copy link

Describe the bug
When using the Link Dialogue, the link text will turn red as if the link is invalid if the link begins with a "#"

Since anchor links were introduced, this seems to be a case of left over outdated behavior or rather that the dialogue was not updated alongside it.

To Reproduce
Steps to reproduce the behavior:

  1. Press CTRL+L on a page
  2. Type a "#" and any other text

Expected behavior
The link text color should ideally not change to red so long as the syntax is valid

One suggestion I could make is displaying it in a slightly grayed color if the link target does not exist (much like the sort of 'ghost pages' in the side bar)

Additionally, in the case of "Prefer short link names for pages" being checked, the "#" should be probably be omitted from the resulting text.

The dialogue box also does not suggest any valid Headings or IDs to link to in the same way it suggests pages.

Screenshots
image

Environment:

Additional context
N/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants