Space admins can create "Menu/Product Groups" and reorder them for display on their marketplace #2361

rosschapman · 2024-04-18T21:15:25Z

Foundational work for #2340.

✋🏻✋🏻✋🏻 Let's get these PRs merged first to reduce cognitive load for reviewers:

Tasks

Add is_section attribute to Marketplace::Tag (db, model, controller, etc..)
Add "Section" label to Tags view
Add Tag editing (view, controller, etc...)
Add sections to Products view sorted by rank prop (slot)
Add tag sorting controller action
Add tag sorting UI (Stimulus Sortable)
Add system spec for marking group tag
Add system spec for ordering of group tags
🌸 Update product tag display to pills

Follow-up tasks (2/N)

🌸 Update tag selection UI to token input

rosschapman · 2024-04-22T19:45:39Z

@zinc-collective/convene-maintainers I'm going to pause dev on this spike for the moment for a gut-check from the committee. 🙏🏻

Gemfile

app/components/svg_component.rb

app/furniture/marketplace/marketplace.rb

app/furniture/marketplace/menu_component.html.erb

app/furniture/marketplace/tags/index.html.erb

app/furniture/marketplace/tags_controller.rb

db/migrate/20240422172820_add_position_to_marketplace_tag.rb

zspencer

I think this is a great start! I left some comments (I had actually read this before I left last weekend but completely forgot to click the submit! Apologies!)

Gemfile

app/components/svg_component.rb

app/furniture/marketplace/marketplace.rb

app/furniture/marketplace/menu_component.html.erb

app/furniture/marketplace/tags_controller.rb

db/migrate/20240422172820_add_position_to_marketplace_tag.rb

app/furniture/marketplace/tags/_form.html.erb

app/furniture/marketplace/menu_component.html.erb

app/furniture/marketplace/tags/_form.html.erb

zspencer

This is great! Ship it!

app/furniture/marketplace/tags_controller.rb

app/furniture/marketplace/tags/index.html.erb

app/furniture/marketplace/marketplace.rb

app/furniture/marketplace/tag.rb

app/furniture/marketplace/tags/index.html.erb

`Marketplace::Product`, `without_group_tag`, implemented in terms of the `Tag.group_tag` scope. Add specs for this new scope.

Bumps [square.rb]() from 37.0.0.20240417 to 38.0.0.20240515. --- updated-dependencies: - dependency-name: square.rb dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [positioning](https://github.com/brendon/positioning) from 0.2.1 to 0.2.2. - [Changelog](https://github.com/brendon/positioning/blob/main/CHANGELOG.md) - [Commits](brendon/positioning@v0.2.1...v0.2.2) --- updated-dependencies: - dependency-name: positioning dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [rexml](https://github.com/ruby/rexml) from 3.2.6 to 3.2.8. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.6...v3.2.8) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [standard](https://github.com/standardrb/standard) from 1.35.1 to 1.36.0. - [Release notes](https://github.com/standardrb/standard/releases) - [Changelog](https://github.com/standardrb/standard/blob/main/CHANGELOG.md) - [Commits](standardrb/standard@v1.35.1...v1.36.0) --- updated-dependencies: - dependency-name: standard dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zee <50284+zspencer@users.noreply.github.com>

Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby) from 1.150.0 to 1.151.0. - [Release notes](https://github.com/aws/aws-sdk-ruby/releases) - [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-ruby/commits) --- updated-dependencies: - dependency-name: aws-sdk-s3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fixes new cop warning --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ross Chapman <rosschapman@users.noreply.github.com>

anaulin

Code-wise this looks good, thank you! I'm fine with this being merged once you can get the build green and the rebasing on latest main sorted out.

My main comment is that I think we should improve the naming and description of "tag groups" and "tags" in user-facing UIs and strings. The goal is to make this as clear to users as possible. But we can make these changes in follow-up PRs.

Calling it a "menu group" doesn't make sense to me (it is not a group of menus). I think some better names could be "product group" or "menu" or maybe "menu tag".

We could either differentiate "tags" from "menus" more clearly in the management UI (maybe even having two separate edit/create places for the two different kinds), or we could instead lean into it and call them "menu tags", and describe them as "special tags that allow you to group a set of your products and control the order in which they are displayed".

anaulin · 2024-05-23T21:37:31Z

app/furniture/marketplace/tags/index.html.erb

+  <div class="flex flex-col gap-4">
+    <div>
+      <h1>Menu Groups</h1>
+      <%- if marketplace.tags.group_tag.empty? %>


I like how in the "Tags" section there is a helpful message ("Adding tags to your products like "vegan" or "discounted" will help shoppers more easily find what they want"). Let's add something similar here, e.g: "Use product groups like "featured" or "produce" to display some of your products together, and to control the order in which products are displayed." (Or some better wording.)

anaulin · 2024-05-23T21:42:38Z

db/seeds.rb

@@ -30,7 +32,15 @@
  description: "A marvelous marketplace for magic merchandise.",
  hero_image: FactoryBot.create(:media)
 )
-FactoryBot.create(:marketplace, :full, room: marketplace_section)
+marketplace = FactoryBot.create(:marketplace, :ready_for_shopping, product_quantity: 16, room: marketplace_section)


I think this code exists in main, and should not be appearing as a diff in this PR.

Ah, it's not actually. You made these changes in this branch with cd5cd4b. ☺️

rosschapman · 2024-05-23T22:11:04Z

@anaulin Agree about cleaning up the copy. April might even have some insight on what language feels more natural from a user perspective.

anaulin · 2024-05-23T23:08:41Z

Asking April for input is a good idea!

anaulin · 2024-05-24T01:16:34Z

Ah, it's not actually. You made these changes in this branch with cd5cd4b

Oh, sorry, I forgot that was in this PR! 🤦🏼‍♀️

rosschapman changed the title ~~Attempts to add edit for tags~~ Space admins can mark marketplace tags as a "section" Apr 18, 2024

rosschapman force-pushed the tag-sections branch 2 times, most recently from 7db7d3c to 757a0fc Compare April 22, 2024 19:05

rosschapman commented Apr 25, 2024

View reviewed changes

zspencer reviewed May 2, 2024

View reviewed changes

rosschapman commented May 2, 2024

View reviewed changes

app/furniture/marketplace/menu_component.html.erb Show resolved Hide resolved

rosschapman changed the title ~~Space admins can mark marketplace tags as a "section"~~ Space admins can mark marketplace tags as a "section" 1/N May 2, 2024

rosschapman marked this pull request as ready for review May 6, 2024 20:14

This was referenced May 6, 2024

Adds positioning Gem #2390

Merged

Adds is_group and position column to Marketplace Tags #2391

Merged

rosschapman changed the title ~~Space admins can mark marketplace tags as a "section" 1/N~~ Space admins can mark marketplace tags as a "section" and reorder them May 6, 2024

rosschapman requested a review from zspencer May 6, 2024 20:30

rosschapman force-pushed the tag-sections branch 2 times, most recently from e3e0591 to 60b12fc Compare May 8, 2024 13:56

Adds tag sorting capability and updates product displays

baed227

rosschapman force-pushed the tag-sections branch from 922f32e to baed227 Compare May 8, 2024 20:40

rosschapman requested review from a team May 9, 2024 00:53

rosschapman changed the title ~~Space admins can mark marketplace tags as a "section" and reorder them~~ Space admins can create "Product Groups" and reorder them for display on their marketplace May 9, 2024

rosschapman commented May 9, 2024

View reviewed changes

app/furniture/marketplace/tags/_form.html.erb Outdated Show resolved Hide resolved

Update app/furniture/marketplace/tags/_form.html.erb

1ba0fea

rosschapman changed the title ~~Space admins can create "Product Groups" and reorder them for display on their marketplace~~ Space admins can create "Menu/Product Groups" and reorder them for display on their marketplace May 9, 2024

zspencer approved these changes May 10, 2024

View reviewed changes

app/furniture/marketplace/tags_controller.rb Show resolved Hide resolved

app/furniture/marketplace/tags/index.html.erb Outdated Show resolved Hide resolved

app/furniture/marketplace/marketplace.rb Outdated Show resolved Hide resolved

anaulin reviewed May 10, 2024

View reviewed changes

app/furniture/marketplace/tag.rb Outdated Show resolved Hide resolved

anaulin reviewed May 10, 2024

View reviewed changes

app/furniture/marketplace/tag.rb Outdated Show resolved Hide resolved

anaulin reviewed May 11, 2024

View reviewed changes

app/furniture/marketplace/tags/index.html.erb Outdated Show resolved Hide resolved

anaulin added 3 commits May 10, 2024 17:10

Improve naming, de-composition and testing of Marketplace::Tag scopes.

d7c5421

Replace Marketplace.products_with_no_group_tags with a scope on

010a988

`Marketplace::Product`, `without_group_tag`, implemented in terms of the `Tag.group_tag` scope. Add specs for this new scope.

Add tagged products to seeds' marketplace.

cd5cd4b

dependabot bot and others added 12 commits May 22, 2024 17:48

Bump selenium-webdriver from 4.20.1 to 4.21.1 (#2412)

feb54e3

Removes Bazaar association from Tags (#2408)

aae219d

Runs yarn after merge

cf1e499

Merge branch 'main' into tag-sections

7bdbd5b

Updates styling and adds test placeholder

94ea17d

Adds specs

a02cd6e

rosschapman requested a review from anaulin May 23, 2024 03:01

rosschapman force-pushed the tag-sections branch from 9fdbb91 to f3674c1 Compare May 23, 2024 21:05

Update seeds

c42c307

rosschapman force-pushed the tag-sections branch from f3674c1 to c42c307 Compare May 23, 2024 21:06

anaulin approved these changes May 23, 2024

View reviewed changes

rosschapman added 3 commits May 23, 2024 17:24

Merge branch 'main' into tag-sections

2b9b494

Oops, add missing dep

a4bae6b

Updates spec

c3a496a

Merge branch 'main' into tag-sections

e6e6b35

rosschapman merged commit 67dc740 into main May 24, 2024
3 checks passed

rosschapman deleted the tag-sections branch May 24, 2024 01:40

This was referenced May 24, 2024

Revert "Space admins can create "Menu/Product Groups" and reorder them for display on their marketplace" #2422

Merged

Roll forward "Revert "Space admins can create "Menu/Product Groups" and reorder them for display on their marketplace"" #2423

Merged

This was referenced May 27, 2024

Marketplace Menus: 🪩🥂🍾✨ and next steps #2426

Open

Marketplace Tags enhancements #2431

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Space admins can create "Menu/Product Groups" and reorder them for display on their marketplace #2361

Space admins can create "Menu/Product Groups" and reorder them for display on their marketplace #2361

rosschapman commented Apr 18, 2024 •

edited

rosschapman commented Apr 22, 2024 •

edited

zspencer left a comment

zspencer left a comment

anaulin left a comment

anaulin May 23, 2024

anaulin May 23, 2024

rosschapman May 24, 2024

rosschapman commented May 23, 2024

anaulin commented May 23, 2024

anaulin commented May 24, 2024

Space admins can create "Menu/Product Groups" and reorder them for display on their marketplace #2361

Space admins can create "Menu/Product Groups" and reorder them for display on their marketplace #2361

Conversation

rosschapman commented Apr 18, 2024 • edited

Tasks

Follow-up tasks (2/N)

rosschapman commented Apr 22, 2024 • edited

zspencer left a comment

Choose a reason for hiding this comment

zspencer left a comment

Choose a reason for hiding this comment

anaulin left a comment

Choose a reason for hiding this comment

anaulin May 23, 2024

Choose a reason for hiding this comment

anaulin May 23, 2024

Choose a reason for hiding this comment

rosschapman May 24, 2024

Choose a reason for hiding this comment

rosschapman commented May 23, 2024

anaulin commented May 23, 2024

anaulin commented May 24, 2024

rosschapman commented Apr 18, 2024 •

edited

rosschapman commented Apr 22, 2024 •

edited