Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds positioning Gem #2390

Merged
merged 1 commit into from
May 6, 2024
Merged

Adds positioning Gem #2390

merged 1 commit into from
May 6, 2024

Conversation

rosschapman
Copy link
Contributor

@rosschapman rosschapman commented May 6, 2024 •
edited

Part of work for #2361. Should be merged first.

@rosschapman rosschapman requested review from a team May 6, 2024 20:23
zspencer
zspencer approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@zspencer zspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hopefully we can do a follow on to rip out ranked-model and not have both gems but for now this lets us move forward with the sortable categories work so ship it.

@rosschapman rosschapman mentioned this pull request May 6, 2024
Merged
10 tasks
@rosschapman
Copy link
Contributor Author

Thanks! Hopefully we can do a follow on to rip out ranked-model and not have both gems but for now this lets us move forward with the sortable categories work so ship it.

Yeah I'll make an issue for this.

@rosschapman rosschapman mentioned this pull request May 6, 2024
Open
@rosschapman rosschapman merged commit 333eca3 into main May 6, 2024
3 checks passed
@rosschapman rosschapman deleted the adds-positioning-gem branch May 6, 2024 20:38
@rosschapman rosschapman mentioned this pull request May 27, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zspencer zspencer zspencer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rosschapman @zspencer