Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space Member may Edit Room directly, rathe than going through Space Edit #710

Merged
merged 23 commits into from
Jun 23, 2022

Conversation

anaulin
Copy link
Member

@anaulin anaulin commented Jun 9, 2022

  • Make the Spotlight play nicely
  • Adding new Furniture should Append the Furniture Placement Edit Form
  • How can we make each slot kind of look nice? Like right now they're all just left-aligned and get as wide as they get.
  • Room Form should look reasonable on a wide-ass screen
  • Furniture without an Edit form should just have a delete action rather than an edit action
  • Furniture Placements should have a Delete action?

zspencer and others added 20 commits June 22, 2022 19:15
Co-authored-by: Ana Ulin <anaulin@users.noreply.github.com>
Co-authored-by: Ana Ulin <anaulin@users.noreply.github.com>
This reverts commit 917a27f.
Apparently `as` is how you indicate polymorphism, which causes Rails to
do some funky junk.
OK, so I learned a bit more about how turbo wants things to work, in
particular the way to use it in a format block! It's very very cool now.
@anaulin anaulin marked this pull request as ready for review June 23, 2022 02:19
@anaulin
Copy link
Member Author

anaulin commented Jun 23, 2022

🦭 of approval!

@zspencer zspencer merged commit 75a900d into development Jun 23, 2022
@zspencer zspencer deleted the 709/edit-mode branch June 23, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants