Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @prabhatsharma
This PR is regarding this issue
There are some notes about this that I think they important the address these issues in the future by creating task about them
1 - The user list returns Searchresponse which is I think is wrong, but I understand that there is gonna be a UI job to change, this can be addressed by creating a new task
2 - For swagger in this first phase I did not change any object without discussing it with maintainers first, for example, it could be a good idea to return errors object every rest endpoint for a more stable API
3 - It could be a good idea to divide posts and put functions in user service, and there are not enough checks for user objects like checking Name, Password, and Role properties
4 - Same handler methods for multiple Rest endpoints is getting problem for putting them in the swagger page, we have to choose one path, little indirection could solve this problem
5 - In the bulk services there is no particular object requests, it is all done with scanner utils with reading line by line, for clarity there can be request object for this