-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code for toml file handling and remove code duplication from new.rs file #152
Comments
These drafts are ready for a quick review and comments. |
I will submit a new pull request to replace the ones I have just closed. |
Can you tell me what issues you have with my three PRs. They are all related. Each pr builds on the previous to create the desired "--article" command line option. I can make one more attempt to get to something you can work with. But they all need to be implemented for the "--article" option to work. |
Hi, @Bas-Man. I apologize for the delay in my response. Thanks for working on this. I hope you can submit a single PR with as less changes as possible to support the |
Nearly all the changes are required. Each change builds on previous to make things clean and maintainable moving forward. |
I have been looking at code regarding issue #130 and which was referenced by pull request number #142.
I have some comments and ideas on how to improve this.
Issues
new.rs
contains a lot of information regarding howSite
andIssue
struct data is to be written to theirtoml
files. I think this can be removed by makingstruct Site{}
andstruct Issue{}
directly responsible for writing their related data to file using the thetoml
crate.Issue
there currently does not appear to be any protection to prevent a user from intentionally overwrite an exitingIssue
.Ideas
struct Site{}
manage its own zine.toml file directly. Work in progress with pr Refactor how Site struct is created #151struct Issue{}
manage its own zine.toml file directly. Work in progress with pr Feat: Add a way to create a new issue by chaining #150struct Article
manage its own data and append it to theIssue
zine.toml. This may have the added benefit of being able to remove an article programatically in the future. This is a work in progress with pr Initial commit to Support new Article features #153. It will requireauthor.rs
to have the Trait FromStr implemented based on my current thinking.The text was updated successfully, but these errors were encountered: