Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ZineScaffold to create project and issue #142

Merged
merged 7 commits into from Jan 11, 2023
Merged

Refactor ZineScaffold to create project and issue #142

merged 7 commits into from Jan 11, 2023

Conversation

Folyd
Copy link
Member

@Folyd Folyd commented Jan 9, 2023 •
edited

Partially resolve #130.

@Folyd Folyd requested a review from l1ch40 January 10, 2023 02:24
@l1ch40
Copy link
Collaborator

l1ch40 commented Jan 10, 2023

Is this feature only issue but not article?

l1ch40
l1ch40 reviewed Jan 10, 2023
View reviewed changes
src/engine.rs Outdated Show resolved Hide resolved
src/new.rs Outdated Show resolved Hide resolved
src/new.rs Outdated Show resolved Hide resolved
@Folyd
Copy link
Member Author

Folyd commented Jan 11, 2023

Is this feature only issue but not article?

Yes, we can submit another PR to support zine new --article.

l1ch40
l1ch40 reviewed Jan 11, 2023
View reviewed changes
src/main.rs Show resolved Hide resolved
@l1ch40
Copy link
Collaborator

l1ch40 commented Jan 11, 2023

LGTM

@Folyd Folyd merged commit 6358d10 into master Jan 11, 2023
@Folyd Folyd deleted the zine-scaffold branch January 11, 2023 16:41
@Bas-Man Bas-Man mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l1ch40 l1ch40 l1ch40 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new article and issue
2 participants
@Folyd @l1ch40