Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z_source column is added at the end of dataset in alignDupes #119

Merged
merged 2 commits into from Jan 10, 2022
Merged

z_source column is added at the end of dataset in alignDupes #119

merged 2 commits into from Jan 10, 2022

Conversation

navinrathore
Copy link
Contributor

@navinrathore navinrathore commented Jan 8, 2022 •
edited

It is fine to have z_source in the beginning in alignLinked() for better user experience. It's an end output file.
This file is mandatory for the newly generated models to test.
Reference GH-95

sonalgoyal
sonalgoyal requested changes Jan 10, 2022
View reviewed changes
Copy link
Member

@sonalgoyal sonalgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignLinked to change too to make it consistent with the match output. Or we can have all the z columns in the beginning. that may be a bigger change for now. so lets change alignlinked and we can revisit later

@sonalgoyal sonalgoyal merged commit 59914dc into zinggAI:main Jan 10, 2022
@navinrathore navinrathore mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonalgoyal sonalgoyal sonalgoyal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@navinrathore @sonalgoyal