Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for float type #95

Closed
doku opened this issue Dec 28, 2021 · 5 comments
Closed

Support for float type #95

doku opened this issue Dec 28, 2021 · 5 comments
Assignees

Comments

@doku
Copy link

doku commented Dec 28, 2021

Support for float or double type for matching. Columns with decimal numbers can't be used for matching right now. It would be useful if these numbers can be used to match within a few +- percentage.

@sonalgoyal
Copy link
Member

@doku are you able to share some data which we can use for testing this?

@sonalgoyal
Copy link
Member

Thanks 🙏🏽 @mliscombe

@navinrathore
Copy link
Contributor

With the above data, we have confirmed that support of float/double and integer data is already present in the Zingg.
However, we have found a bug that would restrict working end-to-end with such data.
We'll fix the same under this issue.

@navinrathore
Copy link
Contributor

The "z_source" column should be added at the end of the record for consistency. The alignDupes() function requires desired change.
The alignLinked() may also require similar change.
The other place of same interest is getFieldDefColumns(). All functions are from DSUtil.java.

navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Jan 8, 2022
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Jan 8, 2022
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Jan 10, 2022
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Jan 10, 2022
navinrathore added a commit to navinrathore/zingg-1 that referenced this issue Jan 12, 2022
sonalgoyal added a commit that referenced this issue Jan 13, 2022
handling null value of datatype Double #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants