new febrl models #121
Merged
new febrl models #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalgoyal
requested changes
Jan 10, 2022
| "zinggDir": "models" | ||
|
|
||
| "modelId": 500, | ||
| "zinggDir": "models", |
There was a problem hiding this comment.
our model ids should be 100 series. also add a modelId.txt file under examples with id and description of models.
navinrathore
force-pushed
the
zNewFebrlModels
branch
2 times, most recently
from
b739b1b
to
e7fdcf9
Compare
navinrathore
force-pushed
the
zNewFebrlModels
branch
from
e7fdcf9
to
4c994c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The febrl models have been updated after
a) changes in config files - areacode, 'exact' for street no, areacode
b) z_source movement at the end of dataset (#95)
c) Blocking tree read/write through spark (#82)