Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add send-to-self transaction and value transfers kinds #1276

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

Oscar-Pepper
Copy link
Contributor

this solves a concern from @juanky201271 that some transactions do not create any value transfers and therefore some information is missing from the UI and also the user has no information about the status of a transaction the migrates funds etc.

  • adds a new transaction and value transfer kind send-to-self so all transaction create at least 1 value transfer
  • renames note-to-self to memo-to-self as there was confusion
  • defines a send-to-self transaction as a sending transaction that does not send to another capability, and is not a shield
  • defines a send-to-self value transfer as a transfer that is created for a send-to-self transaction when there is no memos in the received notes
  • fixes a bug with shield value transfer where is did not check shielded notes were received, meaning t -> t would be listed as a shield

Copy link
Contributor

@fluidvanadium fluidvanadium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i heard this is urgent. it can merge now. i will try to update this comments

@fluidvanadium fluidvanadium merged commit f430b8a into zingolabs:dev Jul 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants