This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Lrzc upgrade 2 #53
Merged
Lrzc upgrade 2 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test in message.rs compiles
Lrzc upgrade 2
Compiling tests
use as u32 when testing blockheight in tests.rs:444
change away from new() to from_parts()
WIP: moving to new_transactiondata() in blaze
This was referenced May 31, 2022
dannasessha
approved these changes
May 31, 2022
There was a problem hiding this comment.
Understanding the provisional nature of the upcoming release, I approve.
Locally, I was able to run the cli (via cargo run) with local lightwalletd and zcashd, on testnet. I tried using several commands, including sending, everything seemed to work well!
cargo test threw many warnings, and had 18 ignored tests, which are supressed failures. We will want to circle back to these ASAP.
test result: ok. 24 passed; 0 failed; 18 ignored;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stop gap PR, we can make a provisional release from it while we upgrade the test code to be compatible with the backwards-incompatible APIs that were introduced upstream.