Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving to dio over http client #712

Open
micimize opened this issue Aug 14, 2020 · 3 comments
Open

Consider moving to dio over http client #712

micimize opened this issue Aug 14, 2020 · 3 comments

Comments

@micimize
Copy link
Collaborator

dio has more features and seems better maintained than http, and has come up when discussing multiple issues: #708 and #592

there is already a gql_dio_link to work off of / contribute to, but might be easier to copy gql_http_link, replace the client, then make tests pass

@jeffscaturro-aka
Copy link

Another point of thought on this topic, in favor of supporting dio, is that we could utilize dio interceptors. While we could write custom links, interceptors still feel more natural and the level of entry for many seems lower. In addition, many clients already have dio interceptors set up for their Rest API if they're already using dio, which there is a good chance they are.

This would help out with issues like #704.

@micimize
Copy link
Collaborator Author

micimize commented Oct 7, 2020

Now that we've migrated to using gql_links in 4.0.0-beta.1 (#648) there is a dio link, which apparently supports http2. I'm not sure how well it works with graphql/client.dart yet, but this is maybe another reason to consider dio (#712) (merging into that issue)

You thought what you needed what http2 support, but it was me, Dio!

@iNoles
Copy link

iNoles commented Oct 31, 2020

gql-dart/gql#157 It seems they are trying to simplified it for allowing custom http library too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants