Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql_flutter): Decouple GraphQLClient Provider #1108

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

budde377
Copy link
Collaborator

This PR provides widgets and hooks variants which does not depend on the GraphQL Client Provider (see #640)

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1108 (5effdf6) into main (90e5d45) will decrease coverage by 0.43%.
The diff coverage is 53.84%.

❗ Current head 5effdf6 differs from pull request most recent head 750ca05. Consider uploading reports for the commit 750ca05 to get more accurate results

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
- Coverage   60.01%   59.57%   -0.44%     
==========================================
  Files          41       41              
  Lines        1528     1561      +33     
==========================================
+ Hits          917      930      +13     
- Misses        611      631      +20     
Impacted Files Coverage Δ
...raphql_flutter/lib/src/widgets/hooks/mutation.dart 0.00% <0.00%> (ø)
...ages/graphql_flutter/lib/src/widgets/mutation.dart 0.00% <0.00%> (ø)
...hql_flutter/lib/src/widgets/hooks/watch_query.dart 68.29% <25.00%> (-10.09%) ⬇️
...s/graphql_flutter/lib/src/widgets/hooks/query.dart 81.25% <50.00%> (-18.75%) ⬇️
...ql_flutter/lib/src/widgets/hooks/subscription.dart 54.16% <50.00%> (-4.53%) ⬇️
...ackages/graphql_flutter/lib/src/widgets/query.dart 100.00% <100.00%> (ø)
.../graphql_flutter/lib/src/widgets/subscription.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e5d45...750ca05. Read the comment docs.

@budde377 budde377 force-pushed the feat-decouple-client-provider branch from b1328aa to 750ca05 Compare April 19, 2022 07:55
@vincenzopalazzo vincenzopalazzo added flutter Issue relates mainly to graphql_flutter labels Apr 21, 2022
@vincenzopalazzo vincenzopalazzo modified the milestone: v5.2.0 Apr 21, 2022
@vincenzopalazzo vincenzopalazzo added the Priority: High High priority to include it inside next release label Apr 22, 2022
@vincenzopalazzo vincenzopalazzo merged commit ff6fda6 into main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flutter Issue relates mainly to graphql_flutter Priority: High High priority to include it inside next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQLProvider should not be hardcoded in GraphQl widgets: Query, CacheProvider...
2 participants