Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: added connected message #1309

Conversation

vytautas-pranskunas-
Copy link
Contributor

@vytautas-pranskunas- vytautas-pranskunas- commented Mar 15, 2023

Fixes / Enhancements

Added message when websocket is connected

Docs

Added message when websocket is connected

Upteda by @vincenzopalazzo

Fixes #1308

@vincenzopalazzo
Copy link
Collaborator

please change the commit header to feat(graphql): print the connection status with ws

@vincenzopalazzo vincenzopalazzo self-assigned this Mar 15, 2023
@vincenzopalazzo vincenzopalazzo added the Priority: Low Low priority, would be cool to include inside the next release label Mar 15, 2023
@vincenzopalazzo vincenzopalazzo added this to the v5.2.0 milestone Mar 15, 2023
@vincenzopalazzo
Copy link
Collaborator

also the CI is complaing

8s
Run make ci_fmt_client
dart pub global run melos run client_analyze --no-select
melos run client_analyze
  └> melos exec -c [1](https://github.com/zino-hofmann/graphql-flutter/actions/runs/4425459030/jobs/7760880769#step:5:1) -- "dart format --set-exit-if-changed . && dart analyze . --fatal-infos"
     └> RUNNING

$ melos exec
  └> dart format --set-exit-if-changed . && dart analyze . --fatal-infos
     └> RUNNING (in 2 packages)

--------------------------------------------------------------------------------
example:
Formatted 3 files (0 changed) in 0.2[7](https://github.com/zino-hofmann/graphql-flutter/actions/runs/4425459030/jobs/7760880769#step:5:8) seconds.
Analyzing ....
No issues found!
example: SUCCESS
--------------------------------------------------------------------------------
graphql:
Formatted lib/src/links/websocket_link/websocket_client.dart
Formatted 54 files (1 changed) in 0.79 seconds.
--------------------------------------------------------------------------------

$ melos exec
  └> dart format --set-exit-if-changed . && dart analyze . --fatal-infos
     └> FAILED (in 1 packages)
        └> graphql (with exit code 1)

melos run client_analyze
  └> melos exec -c 1 -- "dart format --set-exit-if-changed . && dart analyze . --fatal-infos"
     └> FAILED
ScriptException: The script client_analyze failed to execute
make: *** [Makefile:[32](https://github.com/zino-hofmann/graphql-flutter/actions/runs/4425459030/jobs/7760880769#step:5:33): ci_fmt_client] Error 1

@vytautas-pranskunas-
Copy link
Contributor Author

Changed

@vincenzopalazzo
Copy link
Collaborator

Need commit need to be removed 7757b8b

This required to squash your commit with the previous one

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1309 (84c1279) into main (4554a18) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 84c1279 differs from pull request most recent head a9aefc4. Consider uploading reports for the commit a9aefc4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
+ Coverage   63.48%   63.50%   +0.02%     
==========================================
  Files          41       41              
  Lines        1687     1688       +1     
==========================================
+ Hits         1071     1072       +1     
  Misses        616      616              
Impacted Files Coverage Δ
...lib/src/links/websocket_link/websocket_client.dart 80.09% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This reverts commit cb8973bd13fe511ecfaf7864b5f8dbebc1f9b35f.
@vytautas-pranskunas-
Copy link
Contributor Author

squashed

@vincenzopalazzo vincenzopalazzo merged commit 256133a into zino-hofmann:main Mar 15, 2023
@vytautas-pranskunas-
Copy link
Contributor Author

when it will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Low priority, would be cool to include inside the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription stuck with state: Initialising connection
2 participants