Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: response extensions should be optional #1419

Merged

Conversation

kamilkarp
Copy link
Contributor

#1394 made SubscriptionData json always containing extensions. Now extensions in json are only present if response contained them.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.83%. Comparing base (ab3258c) to head (7e9c34b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
+ Coverage   64.63%   64.83%   +0.20%     
==========================================
  Files          41       41              
  Lines        1722     1732      +10     
==========================================
+ Hits         1113     1123      +10     
  Misses        609      609              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamilkarp
Copy link
Contributor Author

@vincenzopalazzo Hi, I've noticed that after merging #1394, tests were failing due to extensions being always present. Sorry for that, here is the fix for that.

@vincenzopalazzo
Copy link
Collaborator

Hi @kamilkarp

No problem :) my fault that I did not catch it during review, but can you fix the formatting of the code?

@kamilkarp
Copy link
Contributor Author

@vincenzopalazzo Analyzer fixed

@vincenzopalazzo vincenzopalazzo merged commit eebac38 into zino-hofmann:main Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants