Polish and withCompletionHandler #17
Conversation
|
yeah, this is a breaking PR, there are many things being changed around |
|
|
||
| import scala.concurrent.ExecutionException | ||
|
|
||
| object java { |
There was a problem hiding this comment.
@sideeffffect Eh, I'd avoid that. What if someone does import zio.interop._ ? Then all subsequent import java.... & java.Smth references will fail. It's the same reason we use zio.interop.catz, not zio.interop.cats – to avoid clashes with a root package.
There was a problem hiding this comment.
OK :D Although I think the old name isn't so bad either
There was a problem hiding this comment.
I wanted to get rid of the concurrent part, because in the future I would like this library to be interop for all things JRE 8, not just for java.util.concurrent
|
@Kaishh anything left to do before final approval and merge? |
There was a problem hiding this comment.
@sideeffffect
Hmm, don't know – it looks good to me, AFAIK you wrote the initial version in the first place? You may merge in case a ZIO invite reached you already, otherwise I may
|
I don't seem to be able to merge, can you please do it @Kaishh |
No description provided.