Skip to content

Commit

Permalink
Make collection-compat a Compile, not Provided dependency. (Downstrea…
Browse files Browse the repository at this point in the history
…m users must have collection-compat on the classpath to call macros) (#380)
  • Loading branch information
neko-kai committed Mar 20, 2023
1 parent d4e9c40 commit 31f5510
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion build.sbt
Expand Up @@ -210,7 +210,7 @@ lazy val `izumi-reflect` = project.in(file("izumi-reflect/izumi-reflect"))
.settings(
libraryDependencies ++= Seq(
"org.scalatest" %% "scalatest" % V.scalatest % Test,
"org.scala-lang.modules" %% "scala-collection-compat" % V.collection_compat % Provided
"org.scala-lang.modules" %% "scala-collection-compat" % V.collection_compat
),
libraryDependencies ++= { if (scalaVersion.value.startsWith("2.")) Seq(
compilerPlugin("org.typelevel" % "kind-projector" % V.kind_projector cross CrossVersion.full),
Expand Down Expand Up @@ -515,6 +515,7 @@ lazy val `izumi-reflect-root` = (project in file("."))
ProblemFilters.exclude[ReversedMissingMethodProblem]("izumi.reflect.macrortti.LightTypeTagRef.longNameInternalSymbol"),
ProblemFilters.exclude[ReversedMissingMethodProblem]("izumi.reflect.macrortti.LightTypeTagRef#AppliedNamedReference.symName"),
ProblemFilters.exclude[ReversedMissingMethodProblem]("izumi.reflect.macrortti.LightTypeTagRef#AppliedNamedReference.prefix"),
ProblemFilters.exclude[ReversedMissingMethodProblem]("izumi.reflect.macrortti.LightTypeTagRef.scalaStyledName"),
ProblemFilters.exclude[Problem]("izumi.reflect.TagMacro.*"),
ProblemFilters.exclude[Problem]("izumi.reflect.macrortti.LightTypeTagImpl.*"),
ProblemFilters.exclude[Problem]("izumi.reflect.macrortti.LightTypeTagImpl#*"),
Expand Down
2 changes: 1 addition & 1 deletion project/Deps.sc
Expand Up @@ -297,7 +297,7 @@ object Izumi {
Artifact(
name = Projects.izumi_reflect_aggregate.izumi_reflect,
libs = Seq(
collection_compat in Scope.Provided.all
collection_compat in Scope.Compile.all
),
depends = Seq(
Projects.izumi_reflect_aggregate.thirdpartyBoopickleShaded
Expand Down

0 comments on commit 31f5510

Please sign in to comment.