Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala Native Scala 3 #267

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Scala Native Scala 3 #267

merged 5 commits into from
Apr 28, 2022

Conversation

sideeffffect
Copy link
Member

@sideeffffect sideeffffect commented Jan 25, 2022 •
edited

closes #264

blocked on scalatest/scalatest#2097
transitively blocked on scala/scala-xml#584

@pshirshov
Copy link
Member

Looks like the build needs to be fixed:

[error] (izumi-reflect-thirdparty-boopickle-shadedNative / update) sbt.librarymanagement.ResolveException: Error downloading org.scala-native:nativelib_native0.4_3:0.4.2
[error]   Not found
[error]   Not found
[error]   not found: /home/runner/.ivy2/localorg.scala-native/nativelib_native0.4_3/0.4.2/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/org/scala-native/nativelib_native0.4_3/0.4.2/nativelib_native0.4_3-0.4.2.pom

@sideeffffect
Copy link
Member Author

Scala Native needs to be updated to 0.4.3, but that is apparently driven by sbtgen (see the PR description)

@pshirshov
Copy link
Member

sbtgen allows you to override external dependencies directly, through GlobalSettings: https://github.com/7mind/sbtgen/blob/26598feb8037747a0b54b98beaae9ec2511e28f4/sbtgen/src/main/scala/izumi/sbtgen/model/GlobalSettings.scala

@neko-kai neko-kai enabled auto-merge (squash) January 26, 2022 17:23
@neko-kai
Copy link
Member

@sideeffffect Thank you! 🙏

@neko-kai
Copy link
Member

@sideeffffect
Sounds like we have to wait for scalatest to publish for 3 Native

[error] sbt.librarymanagement.ResolveException: Error downloading org.scalatest:scalatest_native0.4_3:3.2.10

@sideeffffect
Copy link
Member Author

Oh, I didn't know that, thanks guys.

scalatest

I've amended the PR description. Let's hope they will publish soon 🤞

@sideeffffect sideeffffect mentioned this pull request Feb 1, 2022
Merged
@lolgab
Copy link

lolgab commented Apr 27, 2022

@sideeffffect scalatest 3.2.12 was released with native0.4_3 artifacts :-)

auto-merge was automatically disabled April 27, 2022 22:28

Head branch was pushed to by a user without write access

@sideeffffect
Merge branch 'develop' into scala-native-scala-3
ab7fb56 
# Conflicts:
#	build.sbt
#	project/Deps.sc
#	project/Versions.scala
@sideeffffect
Update versions
1dc8c3d
@sideeffffect
Copy link
Member Author

Thanks @lolgab for the notification!

Good news, @neko-kai and @pshirshov ! We should be able to merge this now 🎉

@pshirshov pshirshov merged commit f4b6a45 into zio:develop Apr 28, 2022
@sideeffffect sideeffffect deleted the scala-native-scala-3 branch April 28, 2022 14:33
@sideeffffect
Copy link
Member Author

Can we, please, have a new version of a the library published? 🙏

@lolgab lolgab mentioned this pull request May 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshirshov pshirshov pshirshov approved these changes

@neko-kai neko-kai Awaiting requested review from neko-kai neko-kai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sideeffffect @pshirshov @neko-kai @lolgab