New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation with akkainterop #164
Conversation
@gastonlucero FYI update to RC18 has been merged yesterday |
docs/overview/akkainterop.md
Outdated
import _root_.akka.actor.typed | ||
import _root_.akka.actor.typed.Behavior | ||
import _root_.akka.actor.typed.scaladsl.Behaviors | ||
import _root_.akka.actor.typed.Scheduler | ||
import _root_.akka.util.Timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think _root_
is unnecessary here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right, but I have errors without _root_
:
error: /zio-actors/docs/overview/akkainterop.md:31:8: object actor is not a member of package zio.actors.akka
import akka.actor.typed.scaladsl.Behaviors
error: zio-actors/docs/overview/akkainterop.md:105:7: not found: value Behaviors
Behaviors.receiveMessage { message =>
Is there another way to do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's look at it. Hmm, I think the problem is import zio.actors._
as it contains akka
package - so the import import akka.actor.typed
is confused, as the error output states: object actor is not a member of package zio.actors.akka
.
Let's try to remove import zio.actors._
and replace it with concrete imports like import zio.actors.akka.{ AkkaTypedActor, AkkaTypedActorRefLocal }
and other required from this package and check if it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right, there are no problems with concrete imports, It works!
As always, thank you for your support.
8ec320e
to
75f90cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Once @mtsokol approves will merge and do a new release 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@softinio LGTM! 🙂
Hi @softinio @mtsokol, I have been working on akka-interop documentation, and this pr contains docs and examples for this feature, but with
DefaultRuntime
, we should wait for RC18?WDYT?
Thanks!