Disable comma separation in values in ZIO for complex configs handled by zio-config #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure YML can accept keys with period characters - Make sure YML tests handle non-empty-list, empty list and table data types - Update ZIO to 2.0.10
guersam
reviewed
Mar 10, 2023
| @@ -59,7 +58,8 @@ object TypesafeConfigProvider { | |||
|
|
|||
| ConfigProvider.fromMap( | |||
| indexedMapWithHiddenDelimiter, | |||
| pathDelim = hiddenDelim | |||
| pathDelim = hiddenDelim, | |||
| seqDelim = if(enableCommaSeparatedValueAsList) "," else hiddenDelim | |||
There was a problem hiding this comment.
Would it be better if the user can provide their own separator like | ? For example, with valueSeparator: Option[String] this line can be like this:
seqDelim = valueSeparator.getOrElse(hiddenDelim)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZIO-Config currently depends fully on ZIO library for its indexed config formats too.
However, as a consequence we reintroduced certain bugs related to the fact that values were considered as a list if there exists a comma. This can hurt a lot of users, who would normally consider list as something that hinted by specific characters such a starting
[and close]in Yaml or-in YML . This implies, for example, users expects only["a", "b", "c"]to be a list and not"a, b, c". If they need"a,b,c"to be considered as a list, then they can setenableCommaSeparatedValueAsList = true. The name is long to understand what's going on.With ZIO-3.0, we can avoid this slight weirdness