Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky ScalaJS test #2645

Closed
kyri-petrou opened this issue Jan 21, 2024 · 9 comments · Fixed by #2670
Closed

Flaky ScalaJS test #2645

kyri-petrou opened this issue Jan 21, 2024 · 9 comments · Fixed by #2670
Labels
💎 Bounty bug Something isn't working 💰 Rewarded

Comments

@kyri-petrou
Copy link
Collaborator

Leaving this one here as it happened to me on more than one occasion, and it might need to be addressed. It seems that one of the ScalaJS tests is flaky (see the most recent failure here)

The test suite fails with the following:

+ ClientSpec
  + HTTP
    - Get
      ✗ Result was false
      string.startsWith("<!doctype html>")
      string = "<!doctype ht"
      at /home/runner/work/zio-http/zio-http/zio-http/js/src/test/scala/zio/http/JSClientSpec.scala:14 

[info] 
[info]     - ClientSpec / HTTP / Get
[info]       ✗ Result was false
[info]       string.startsWith("<!doctype html>")
[info]       string = "<!doctype ht"
[info]       at /home/runner/work/zio-http/zio-http/zio-http/js/src/test/scala/zio/http/JSClientSpec.scala:14 
[info] 
[info] Done
[error] Failed tests:
[error] 	zio.http.JSClientSpec
@kyri-petrou kyri-petrou added the bug Something isn't working label Jan 21, 2024
@kyri-petrou
Copy link
Collaborator Author

Looking at some other PRs, this seems to be a relatively common occurrence, e.g., https://github.com/zio/zio-http/actions/runs/7599763437/job/20697157555?pr=2643

@kyri-petrou kyri-petrou mentioned this issue Jan 21, 2024
Merged
@jdegoes
Copy link
Member

jdegoes commented Feb 8, 2024

/bounty $100

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 8, 2024 •
edited
Loading

💎 $100 bounty created by ZIO
🙋 If you start working on this, comment /attempt #2645 along with your implementation plan
👉 To claim this bounty, submit a pull request that includes the text /claim #2645 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to zio/zio-http!

👉 Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @urbit-pilled Feb 8, 2024, 3:42:53 PM #2669
🟢 @987Nabil #2670

@urbit-pilled
Copy link
Contributor

I think this is due to Google rate-limiting, we could try another site.

@urbit-pilled
Copy link
Contributor

urbit-pilled commented Feb 8, 2024 •
edited by algora-pbc bot
Loading

/attempt

Algora profile Completed bounties Tech Active attempts Options
@urbit-pilled    1 ZIO bounty
+ 1 bounty from 1 project
JavaScript, Scheme,
Scala & more
Cancel attempt

@urbit-pilled urbit-pilled mentioned this issue Feb 8, 2024
Merged
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 8, 2024

💡 @urbit-pilled submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@987Nabil 987Nabil mentioned this issue Feb 8, 2024
Merged
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 8, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 12, 2024

🎉🎈 @987Nabil has been awarded $100! 🎈🎊

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 12, 2024

🎉🎈 @urbit-pilled has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty bug Something isn't working 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flaky JS Test 987Nabil/zio-http
3 participants
@jdegoes @kyri-petrou @urbit-pilled