Flaky JS Test #2670
Merged
Flaky JS Test #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2670 +/- ##
=======================================
Coverage 64.55% 64.55%
=======================================
Files 145 145
Lines 8607 8607
Branches 1521 1521
=======================================
Hits 5556 5556
Misses 3051 3051 ☔ View full report in Codecov by Sentry. |
987Nabil
force-pushed
the
flaky-js-test
branch
from
d13aea1
to
685918c
Compare
jdegoes
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real issue of this test is, that we have to call a remote address. But since we have no js backend, I don't see a easy way to create a local server. I don't expect that a different URL will help either, since this seems to be network hiccups of the runners. I guess
@ flakyis our best option.fixes #2645
/claim #2645