Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Propagate FiberRef To HttpRuntime #1379

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Fix: Propagate FiberRef To HttpRuntime #1379

merged 2 commits into from
Jul 31, 2022

Conversation

adamgfraser
Copy link
Contributor

Resolves #1352.

@tusharmath tusharmath added the bug Something isn't working label Jul 30, 2022
@tusharmath tusharmath enabled auto-merge (squash) July 30, 2022 14:15
@gciuloaica
Copy link
Collaborator

gciuloaica commented Jul 30, 2022

@adamgfraser I have tested the change and it is working fine. The proper logger is used. Thank you.
However, it seems that are some issues with the tests.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #1379 (4b3a8a1) into main (66b571c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
- Coverage   60.79%   60.78%   -0.02%     
==========================================
  Files          71       71              
  Lines        2482     2481       -1     
  Branches       84       84              
==========================================
- Hits         1509     1508       -1     
  Misses        973      973              
Impacted Files Coverage Δ
...ttp/src/main/scala/zhttp/service/HttpRuntime.scala 86.20% <100.00%> (-0.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tusharmath tusharmath changed the title Propagate FiberRefs To Http Runtime Fix: Propagate FiberRef To HttpRuntime Jul 31, 2022
@tusharmath
Copy link
Collaborator

Thank you Adam! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger doesn't propagate to Http
4 participants