Extend support for various content encodings #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitksingh1490
requested review from
dinojohn,
fenilkanjani,
pranjalnadhani,
ravisharnagat,
ShrutiVerma97 and
tusharmath
as code owners
tusharmath
reviewed
Apr 15, 2021
amitksingh1490
changed the title
amitksingh1490
changed the title
tusharmath
changed the title
tusharmath
reviewed
Apr 17, 2021
|
|
||
| object HttpContent { | ||
| final case class Complete[A](data: A) extends HttpContent[Any, A] | ||
| final case class Chunked[R, A](data: ZStream[R, Nothing, A]) extends HttpContent[R, A] | ||
| final case class StringEncoded(string: String) extends HttpContent[Any, Nothing] |
There was a problem hiding this comment.
Suggested change
| final case class StringEncoded(string: String) extends HttpContent[Any, Nothing] | |
| final case object Empty extends HttpContent[Any, Nothing] | |
| final case class StringEncoded(string: String) | |
| extends HttpContent[Any, Nothing] |
tusharmath
reviewed
Apr 17, 2021
| } | ||
|
|
||
| object Request { | ||
| val emptyContent: HttpContent.Complete[String] = HttpContent.Complete("") | ||
| final case class Data(headers: List[Header], content: HttpContent[Any, String]) | ||
| val emptyContent: HttpContent.StringEncoded = HttpContent.StringEncoded("") |
There was a problem hiding this comment.
Suggested change
| val emptyContent: HttpContent.StringEncoded = HttpContent.StringEncoded("") | |
| val emptyContent: HttpContent[Any, Nothing]= HttpContent.empty |
tusharmath
reviewed
Apr 17, 2021
|
|
||
| import java.io.{PrintWriter, StringWriter} | ||
|
|
||
| trait ResponseOps { | ||
| private val defaultStatus = Status.OK | ||
| private val defaultHeaders = Nil | ||
| private val emptyContent = HttpContent.Complete("") | ||
| private val emptyContent = HttpContent.StringEncoded("") |
There was a problem hiding this comment.
Suggested change
| private val emptyContent = HttpContent.StringEncoded("") | |
| private val emptyContent = HttpContent.empty |
tusharmath
reviewed
Apr 17, 2021
| final case class StringEncoded(string: String) extends HttpContent[Any, Nothing] | ||
| final case class ByteEncoded(data: Chunk[Byte]) extends HttpContent[Any, Nothing] | ||
| final case class ByteBufEncoded(byteBuf: ByteBuf) extends HttpContent[Any, Nothing] | ||
| final case class ByteBufEncodedM[R, E](byteBuf: ZIO[R, E, ByteBuf]) extends HttpContent[R, E] |
There was a problem hiding this comment.
Suggested change
| final case class ByteBufEncodedM[R, E](byteBuf: ZIO[R, E, ByteBuf]) extends HttpContent[R, E] |
tusharmath
reviewed
Apr 17, 2021
| status: Status = defaultStatus, | ||
| headers: List[Header] = defaultHeaders, | ||
| content: HttpContent[R, String] = emptyContent, | ||
| ): Response.HttpResponse[R] = | ||
| content: HttpContent[R, Nothing] = emptyContent, |
There was a problem hiding this comment.
Suggested change
| content: HttpContent[R, Nothing] = emptyContent, | |
| content: HttpContent[R, E] = emptyContent, |
tusharmath
reviewed
Apr 17, 2021
| case _ => Option.empty | ||
| case HttpContent.StringEncoded(string) => Option(string) | ||
| case HttpContent.ByteEncoded(data) => Option(data.map(_.toChar).mkString) | ||
| case HttpContent.ByteBufEncoded(byteBuf) => Option(byteBuf.toString(HTTP_CHARSET)) |
There was a problem hiding this comment.
byteBuf.toString is an effectful function.
tusharmath
reviewed
Apr 17, 2021
tusharmath
reviewed
Apr 17, 2021
amitksingh1490
force-pushed
the
fix/httpcontent-byte-array
branch
from
fb6ccaa
to
cc1b8c8
Compare
amitksingh1490
added
enhancement
amitksingh1490
force-pushed
the
fix/httpcontent-byte-array
branch
from
5a749d7
to
5ea68d5
Compare
tusharmath
reviewed
Apr 17, 2021
tusharmath
reviewed
Apr 18, 2021
tusharmath
reviewed
Apr 18, 2021
tusharmath
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.