Call error callback for ZIO die failures

[vigoo]

Resolves #1973

[codecov-commenter]

Codecov Report

Base: 64.30% // Head: 64.31% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (36faf00) compared to base (fe43dc5).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
+ Coverage   64.30%   64.31%   +0.01%     
==========================================
  Files         193      193              
  Lines        5922     5924       +2     
  Branches      217      221       +4     
==========================================
+ Hits         3808     3810       +2     
  Misses       2114     2114              

Impacted Files	Coverage Δ
...a/zio/http/netty/server/ServerInboundHandler.scala	86.11% <100.00%> (+0.26%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[adamgfraser]

Maybe the error callback should be a function Cause[Nothing] => ZIO[Any, Nothing, Any]?

This is also pushing a little on whether the exit should really be ZIO[Any, Nothing, Response].

[vigoo]

Maybe. I think probably it's original goal was only to report netty exceptions, but I think the linked user request to also call it with ZIO die failures from handlers is reasonable. But I did not think of changing the callback type itself.

[vigoo]

Changed to Cause[Nothing]