Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing streaming response when compression is enabled #1981

Merged
merged 11 commits into from
Feb 18, 2023

Conversation

vigoo
Copy link
Contributor

@vigoo vigoo commented Feb 7, 2023

Resolves #1977

@github-actions github-actions bot added the bug Something isn't working label Feb 7, 2023
@jdegoes
Copy link
Member

jdegoes commented Feb 8, 2023

We should add a test here to prevent regression (when it's ready for review).

@vigoo vigoo marked this pull request as ready for review February 18, 2023 13:11
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Base: 61.95% // Head: 62.16% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (c2d9c51) compared to base (6e597fd).
Patch coverage: 58.33% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1981      +/-   ##
==========================================
+ Coverage   61.95%   62.16%   +0.21%     
==========================================
  Files         196      196              
  Lines        5864     5849      -15     
  Branches      213      208       -5     
==========================================
+ Hits         3633     3636       +3     
+ Misses       2231     2213      -18     
Impacted Files Coverage Δ
...rc/main/scala/zio/http/netty/NettyBodyWriter.scala 37.50% <37.50%> (+16.44%) ⬆️
zio-http/src/main/scala/zio/http/Body.scala 85.18% <100.00%> (+1.54%) ⬆️
...p/netty/client/ClientInboundStreamingHandler.scala 85.71% <100.00%> (+1.09%) ⬆️
...o-http/src/main/scala/zio/http/netty/package.scala 100.00% <100.00%> (+4.76%) ⬆️
...o/http/netty/server/ServerChannelInitializer.scala 90.00% <100.00%> (ø)
...a/zio/http/netty/server/ServerInboundHandler.scala 85.98% <100.00%> (+0.13%) ⬆️
.../scala/zio/http/model/headers/HeaderModifier.scala 17.64% <0.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigoo vigoo enabled auto-merge (squash) February 18, 2023 13:42
@vigoo vigoo merged commit e8b7556 into main Feb 18, 2023
@vigoo vigoo deleted the fix-streaming-response branch February 18, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream responses reported as compressed, even though they are not
3 participants