Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Interruption Issue #1994

Merged
merged 55 commits into from
Feb 19, 2023
Merged

Investigate Interruption Issue #1994

merged 55 commits into from
Feb 19, 2023

Conversation

adamgfraser
Copy link
Contributor

No description provided.

@mergify
Copy link

mergify bot commented Feb 13, 2023

⚠️ The sha of the head commit of this PR conflicts with #1966. Mergify cannot evaluate rules on this PR. ⚠️

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Base: 62.16% // Head: 62.23% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (859eb29) compared to base (e8b7556).
Patch coverage: 75.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1994      +/-   ##
==========================================
+ Coverage   62.16%   62.23%   +0.07%     
==========================================
  Files         196      196              
  Lines        5849     5850       +1     
  Branches      208      220      +12     
==========================================
+ Hits         3636     3641       +5     
+ Misses       2213     2209       -4     
Impacted Files Coverage Δ
...io-http/src/main/scala/zio/http/ClientDriver.scala 100.00% <ø> (ø)
...cala/zio/http/netty/client/NettyClientDriver.scala 100.00% <ø> (ø)
...main/scala/zio/http/netty/server/NettyDriver.scala 100.00% <ø> (ø)
zio-http/src/main/scala/zio/http/ZClient.scala 26.72% <66.66%> (-0.24%) ⬇️
...la/zio/http/netty/client/NettyConnectionPool.scala 75.00% <100.00%> (ø)
...a/zio/http/netty/client/ClientInboundHandler.scala 96.77% <0.00%> (+16.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vigoo vigoo linked an issue Feb 19, 2023 that may be closed by this pull request
@vigoo vigoo merged commit 9c0a439 into main Feb 19, 2023
@vigoo vigoo deleted the interruption branch February 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Request Interruption Not Working as Expected
4 participants