-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #2000, #2001 #2005
fixes #2000, #2001 #2005
Conversation
Codecov ReportBase: 62.23% // Head: 62.59% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
+ Coverage 62.23% 62.59% +0.35%
==========================================
Files 196 204 +8
Lines 5850 6047 +197
Branches 220 232 +12
==========================================
+ Hits 3641 3785 +144
- Misses 2209 2262 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
val requestHandlers = Memoized[Routes.Single[R, _ <: E, _, _, M], EndpointServer[R, _ <: E, _, _, M]] { | ||
handledApi => | ||
EndpointServer(handledApi) | ||
} | ||
|
||
Http | ||
.collectZIO[Request] { case (request: Request) => | ||
val handler = handlerTree.lookup(request) | ||
.collectZIO[Request] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use fromOptionalHandlerZIO
and then no need to evaluate the lookup function twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, exactly what I was looking for!
No description provided.